Allow to manually specify the backend for an analysis #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overloads help the type checker to figure out the return type, which is different when return_raw_result == False
This allows to use multiple backends side-by-side. If the backend is not specified, the analysis decorator will pass the default backend to the analysis.
The order of the 'return_raw_result' and 'backend' parameters are now not checked anymore, it is sufficient to make them keyword-only parameters (which is enforced).
jwmbeenakker
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the backend is determined in every analysis using
get_backend, so analyses will always be executed in the default backend. Although this will not occur very often, this makes it difficult to run multiple backends side-by-side. This PR adds abackendparameter to each analysis. By default, thevisisipy.analysis.base.analysisdecorator will automatically supply the configured backend, but if a different backend is used instead, this backend will be used by the analysis.Furthermore, instead of forcing
return_raw_resultto be the last parameter,return_raw_resultandbackendare now forced to be keyword-only parameters.