Create macos app bundles from build script #2270

bjeurissen · 2021-01-27T10:19:32Z

./build app_bundles

will create the necessary app bundle wrappers for macos

Running a subsequent

./build

will revert to 'normal' binaries.

maxpietsch · 2021-02-01T16:02:55Z

App integration seems to work after symlinking to /Applications.

The logic is slightly modified making app bundles persistent: build app bundles if they are requested or if old app bundles exist and if it is necessary to update them because mrview or shview are updated.

I modified build so that scripts that replace the binaries have the same date to avoid needless relinking. While at it, also preventing recreating the app bundles if their binaries did not change.

This allows using plain old ./build without forcing (a subsequent) ./build app_bundle call if app bundles are used.

➜  ./build app_bundles
...
Creating macOS app bundle for mrview
Creating macOS app bundle for shview
➜  touch src/gui/mrview/colourmap_menu.cpp
➜  ./build
(1/2) [CC] tmp/src/gui/mrview/colourmap_menu.o
(2/2) [LB] bin/mrview
Creating macOS app bundle for mrview
➜ ./build
➜  
➜  ./build clean
...
delete app: bin/MRView.app
delete app: bin/SHView.app

bjeurissen · 2021-02-02T08:09:35Z

Great! Thanks! I was struggling a bit with figuring out the mechanics of the build script...

…the app bundles

maxpietsch · 2021-02-02T15:03:41Z

How about integrating symlink_app_bundles into set_path?

bjeurissen · 2021-02-02T16:00:45Z

How about integrating symlink_app_bundles into set_path?

I just had the exact same thought! It avoids clutter...

maxpietsch · 2021-02-03T09:57:34Z

Couldn't find documentation so tried it out: If the app exist in both /Applications and in ~/Applications spotlight shows both together with the resolved symbolic link location

and double click integration picks up the one in the user's home.

bjeurissen · 2021-02-03T12:21:13Z

It should work on linux now as well. Tested only on ubuntu 20.04.2.

In summary, what ./set_path now does is:

on macos:
- without -remove
  - add mrtrix bin directory to the PATH variable in the appropriate dot files in ~
  - create symbolic links to mrtrix application bundles in ~/Applications
- with -remove
  - remove mrtrix bin directory from the PATH variable in the appropriate dot files in ~
  - remove symbolic links to mrtrix application bundles in ~/Applications
on linux:
- without -remove
  - add mrtrix bin directory to the PATH variable in the appropriate dot files in ~
  - run xdg-* install commands
- with -remove
  - remove mrtrix bin directory from the PATH variable in the appropriate dot files in ~
  - run xdg-* uninstall commands

bjeurissen · 2021-02-03T12:22:49Z

Couldn't find documentation so tried it out: If the app exist in both /Applications and in ~/Applications spotlight shows both together with the resolved symbolic link location

and double click integration picks up the one in the user's home.

Thanks! I think that works out fine!

bjeurissen · 2021-02-03T12:49:52Z

@jdtournier: one thing I did notice, is that nii.gz and mif.gz are not handled on Linux, despite them being mentioned in the XML file. Is this supposed to work?

It is not handled on macos either, apart from being able to right click .gz files and choosing to open them with mrview, because I also registered .gz.

jdtournier · 2021-02-03T12:57:30Z

OK, running ./set_path works on Linux as far as I can tell. I don't get the right icons in the file manager for the .nii.gz files, but that's presumably because the .gz mime types overrides that. It does open correctly in mrview though, so that's good.

What doesn't work is running ./set_path remove. Nothing seems to happen: the PATH is still there in ~/.bashrc, the icons are still registered, the mime types are still listed, and the mrview application is also still available. But the output suggests this should all have been dealt with. Not sure what's going on...

bjeurissen · 2021-02-03T15:35:43Z

What doesn't work is running ./set_path remove. Nothing seems to happen: the PATH is still there in ~/.bashrc, the icons are still registered, the mime types are still listed, and the mrview application is also still available. But the output suggests this should all have been dealt with. Not sure what's going on...

it should be ./set_path -remove. ./set_path remove will add the PATH info to the file remove

bjeurissen · 2021-02-03T15:42:04Z

OK, running ./set_path works on Linux as far as I can tell. I don't get the right icons in the file manager for the .nii.gz files, but that's presumably because the .gz mime types overrides that. It does open correctly in mrview though, so that's good.

If you double-click a nii.gz it opens in mrview? That does not happen on my ubuntu installation. I just opens in archive manager... And there is also no option to right-click and choose MRview like there is on macos. Where could these different behaviors originate from?

jdtournier · 2021-02-03T15:50:37Z

What desktop environment are you running in? I'm on Gnome 3.38, and that offers a right-click option to open with another application...

jdtournier · 2021-02-03T16:02:59Z

it should be ./set_path -remove. ./set_path remove will add the PATH info to the file remove

🤦

Everything works perfect... Only suggestion is to somehow document how to use the command. Not sure how best to do this, but obvious thing would be to print out purpose and usage with anything that looks like the -help option...?

bjeurissen · 2021-02-03T18:36:07Z

What desktop environment are you running in? I'm on Gnome 3.38, and that offers a right-click option to open with another application...

Gnome 3.36.8. I have that option, but then I have to manually select MRview from the list of applications

jdtournier · 2021-02-03T19:36:55Z

I have to manually select MRview from the list of applications

I did too, the first time. But presumably you only have to set this once, right?

Lestropie · 2021-02-03T23:29:37Z

With the increased scope of set_path, is "set_path" still an appropriate name? It's starting to look more like an "installation" of sorts...

jdtournier · 2021-02-04T10:08:09Z

Yes, you're right that set_path no longer reflects all it does. Not sure we should rename it to anything that suggests installation as such though - I'd take that as suggesting copying the executables into some standard location, whereas this script leaves them in place. It's more like 'registering' the software with the system. Not sure what term would be appropriate here...

bjeurissen · 2021-02-04T12:15:52Z

On my ubuntu system, this is placed on my desktop:

But it does not use the right icon and when I click it, it just opens in a text editor. This is not supposed to happen, right?

That said, I don't like it when stuff is added to my desktop, so could we just drop the xdg-desktop-icon call? Still puzzled why it does not work though ...

jdtournier · 2021-02-04T17:23:39Z

OK, I don't see any icons on my desktop since GNOME shell running on Wayland doesn't support showing them... Must say I've not really missed them, but it does mean I'd not noticed this as a problem. You could easily ditch the xdg-desktop-icon call, the important one is the xdg-desktop-menu call, I think.

bjeurissen · 2021-02-04T22:29:20Z

OK, I don't see any icons on my desktop since GNOME shell running on Wayland doesn't support showing them... Must say I've not really missed them, but it does mean I'd not noticed this as a problem. You could easily ditch the xdg-desktop-icon call, the important one is the xdg-desktop-menu call, I think.

Yes, and that one works :)

bjeurissen · 2022-12-02T12:17:31Z

Just tested with latest dev and seems to be in pretty good shape (especially thanks to the commits by @maxpietsch)!

Maybe still requires a few linux users double checking that ./set_path operates as expected. I agree that the name set_path is not ideal, but keeping it is also convenient.

Also, I was thinking we could remove the app_bundles option and always enable the mode when building for macOS.

daljit46 · 2024-06-07T13:12:58Z

Closing since #2739 was merged.

bjeurissen added 2 commits January 22, 2021 16:09

Add initial support for macOS application bundles

dd2184b

Cleanup

d92f893

bjeurissen requested review from dchristiaens and maxpietsch January 27, 2021 10:19

maxpietsch added 2 commits February 1, 2021 16:22

build: app_bundle: use file dates of mrview/shview for app bundle

287ba4a

build: app_bundles: automatically update app bundles if required

759fb58

maxpietsch force-pushed the app_bundles branch from 0d50d25 to 759fb58 Compare February 1, 2021 15:58

maxpietsch approved these changes Feb 1, 2021

View reviewed changes

maxpietsch added 2 commits February 1, 2021 17:33

build clean: remove app bundles

0851996

build: make app_bundles if they do not exist

388a964

bjeurissen added 4 commits February 2, 2021 09:13

Small typo in mrtrix-mrview.plist

8b4903d

Update copyright notice in mrtrix-shview.plist

bf7cec7

Add helper script to create symlinks in local Applications folder to …

85956f3

…the app bundles

Fix indentation in wrappers

e15fc9d

Move app bundle symlinking to set_path

6cda6a4

bjeurissen added 3 commits February 3, 2021 12:18

Add setup of linux mime handling and desktop shortcuts to set_path

671167f

Clean up

1f4795f

Removed install_mime_types.sh

328503d

bjeurissen added 2 commits February 4, 2021 23:30

Don't put shortcut on linux desktop

029cab5

Fix

4b9cd0d

bjeurissen force-pushed the app_bundles branch from 8ed9832 to 4b9cd0d Compare February 25, 2021 20:21

jdtournier added this to the 3.1.0 updates milestone Nov 30, 2022

jdtournier added enhancement build labels Nov 30, 2022

jdtournier force-pushed the dev branch from 51544a7 to 1786f71 Compare December 6, 2022 12:21

jdtournier and others added 3 commits December 6, 2022 16:21

Merge remote-tracking branch 'github/dev' into app_bundles_take2

0635d45

Add explicit encoding when opening file

dc673ef

Fix erroneous unused variable warning

cf20916

jdtournier force-pushed the app_bundles branch from e391dbe to cf20916 Compare December 6, 2022 16:22

daljit46 closed this Jun 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create macos app bundles from build script #2270

Create macos app bundles from build script #2270

bjeurissen commented Jan 27, 2021

maxpietsch commented Feb 1, 2021 •

edited

Loading

bjeurissen commented Feb 2, 2021

maxpietsch commented Feb 2, 2021

bjeurissen commented Feb 2, 2021

maxpietsch commented Feb 3, 2021

bjeurissen commented Feb 3, 2021 •

edited

Loading

bjeurissen commented Feb 3, 2021

bjeurissen commented Feb 3, 2021 •

edited

Loading

jdtournier commented Feb 3, 2021

bjeurissen commented Feb 3, 2021

bjeurissen commented Feb 3, 2021

jdtournier commented Feb 3, 2021

jdtournier commented Feb 3, 2021

bjeurissen commented Feb 3, 2021 •

edited

Loading

jdtournier commented Feb 3, 2021

Lestropie commented Feb 3, 2021

jdtournier commented Feb 4, 2021

bjeurissen commented Feb 4, 2021 •

edited

Loading

jdtournier commented Feb 4, 2021

bjeurissen commented Feb 4, 2021

bjeurissen commented Dec 2, 2022

daljit46 commented Jun 7, 2024

Create macos app bundles from build script #2270

Create macos app bundles from build script #2270

Conversation

bjeurissen commented Jan 27, 2021

maxpietsch commented Feb 1, 2021 • edited Loading

bjeurissen commented Feb 2, 2021

maxpietsch commented Feb 2, 2021

bjeurissen commented Feb 2, 2021

maxpietsch commented Feb 3, 2021

bjeurissen commented Feb 3, 2021 • edited Loading

bjeurissen commented Feb 3, 2021

bjeurissen commented Feb 3, 2021 • edited Loading

jdtournier commented Feb 3, 2021

bjeurissen commented Feb 3, 2021

bjeurissen commented Feb 3, 2021

jdtournier commented Feb 3, 2021

jdtournier commented Feb 3, 2021

bjeurissen commented Feb 3, 2021 • edited Loading

jdtournier commented Feb 3, 2021

Lestropie commented Feb 3, 2021

jdtournier commented Feb 4, 2021

bjeurissen commented Feb 4, 2021 • edited Loading

jdtournier commented Feb 4, 2021

bjeurissen commented Feb 4, 2021

bjeurissen commented Dec 2, 2022

daljit46 commented Jun 7, 2024

maxpietsch commented Feb 1, 2021 •

edited

Loading

bjeurissen commented Feb 3, 2021 •

edited

Loading

bjeurissen commented Feb 3, 2021 •

edited

Loading

bjeurissen commented Feb 3, 2021 •

edited

Loading

bjeurissen commented Feb 4, 2021 •

edited

Loading