Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to create tarball for Linux #2807

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Add workflow to create tarball for Linux #2807

merged 6 commits into from
Feb 28, 2024

Conversation

daljit46
Copy link
Member

@daljit46 daljit46 commented Feb 15, 2024 •
edited
Loading

This PR adds a new GitHub Actions workflow to generate self-contained tarballs for Linux releases. To achieve this, mrtrix3 is built on Ubuntu 20.04 and dependencies are packaged with the help of linuxdeploy.
In theory, this will allow users to run MRtrix3 on any distro with a version of glibc >= 2.31 (users may still need to install essential packages such as OpenGL).

I've tested this on fresh installs of (using Gnome Boxes):

  • Ubuntu 20.04 LTS
  • Ubuntu 22.04 LTS
  • Fedora 39
  • openSUSE Leap 15.5

If there are distros that you think should be tested, please let me know.

There are still some things to work out:

  • Bundle script to install mrview icons and desktop files.
  • Bundle script to add ./bin to PATH.

We already have these scripts in our codebase, but they may require modifications to work as expected.

@daljit46 daljit46 self-assigned this Feb 15, 2024
@daljit46 daljit46 marked this pull request as draft February 15, 2024 13:12
@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@daljit46 daljit46 force-pushed the tarball_packaging branch 2 times, most recently from 1c95cb4 to 6c56979 Compare February 15, 2024 14:46
@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@daljit46
Copy link
Member Author

The build workflow has now been simplified by adding a new bash script package-linux-tarball.sh. This allows an easier testing of the workflow on a local Ubuntu system.

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@Lestropie Lestropie mentioned this pull request Feb 26, 2024
Closed
@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@daljit46 daljit46 marked this pull request as ready for review February 27, 2024 11:07
@github-actions GitHub Actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@daljit46
Copy link
Member Author

This can now be merged. May need to do some changes to the packagiing script after dealing with #2827, but can handle that later.

@daljit46 daljit46 requested review from jdtournier and a team February 27, 2024 11:16
@daljit46 daljit46 mentioned this pull request Feb 27, 2024
Merged
@daljit46 daljit46 merged commit 9dcc890 into dev Feb 28, 2024
6 checks passed
@daljit46 daljit46 deleted the tarball_packaging branch February 28, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdtournier jdtournier Awaiting requested review from jdtournier

Assignees

@daljit46 daljit46

Labels
build CI/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daljit46