Move non-templated function definitions out of header files in mrtrix.h and stats.h #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+148
to
+149
| else | ||
| return text; |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [readability-else-after-return]
Suggested change
| else | |
| return text; | |
| return text; |
daljit46
changed the title
| return 1; | ||
| if (arg[0] == '\0' || arg[1] == '\0' || arg[2] == '\0') | ||
| return 0; | ||
| const unsigned char *uarg = reinterpret_cast<const unsigned char *>(arg); |
There was a problem hiding this comment.
warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
const unsigned char *uarg = reinterpret_cast<const unsigned char *>(arg);
^| if (arg[0] == '\0' || arg[1] == '\0' || arg[2] == '\0') | ||
| return 0; | ||
| const unsigned char *uarg = reinterpret_cast<const unsigned char *>(arg); | ||
| if (uarg[0] == 0xE2 && uarg[1] == 0x80 && (uarg[2] >= 0x90 && uarg[2] <= 0x95)) |
There was a problem hiding this comment.
warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
if (uarg[0] == 0xE2 && uarg[1] == 0x80 && (uarg[2] >= 0x90 && uarg[2] <= 0x95))
^| if (arg[0] == '\0' || arg[1] == '\0' || arg[2] == '\0') | ||
| return 0; | ||
| const unsigned char *uarg = reinterpret_cast<const unsigned char *>(arg); | ||
| if (uarg[0] == 0xE2 && uarg[1] == 0x80 && (uarg[2] >= 0x90 && uarg[2] <= 0x95)) |
There was a problem hiding this comment.
warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
if (uarg[0] == 0xE2 && uarg[1] == 0x80 && (uarg[2] >= 0x90 && uarg[2] <= 0x95))
^| if (arg[0] == '\0' || arg[1] == '\0' || arg[2] == '\0') | ||
| return 0; | ||
| const unsigned char *uarg = reinterpret_cast<const unsigned char *>(arg); | ||
| if (uarg[0] == 0xE2 && uarg[1] == 0x80 && (uarg[2] >= 0x90 && uarg[2] <= 0x95)) |
There was a problem hiding this comment.
warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
if (uarg[0] == 0xE2 && uarg[1] == 0x80 && (uarg[2] >= 0x90 && uarg[2] <= 0x95))
^| if (arg[0] == '\0' || arg[1] == '\0' || arg[2] == '\0') | ||
| return 0; | ||
| const unsigned char *uarg = reinterpret_cast<const unsigned char *>(arg); | ||
| if (uarg[0] == 0xE2 && uarg[1] == 0x80 && (uarg[2] >= 0x90 && uarg[2] <= 0x95)) |
There was a problem hiding this comment.
warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
if (uarg[0] == 0xE2 && uarg[1] == 0x80 && (uarg[2] >= 0x90 && uarg[2] <= 0x95))
^
daljit46
force-pushed
the
slim_mrtrix_stats_headers
branch
from
6dad491 to
0faeec3
Compare
Also removes directly used header files
Also removes directly unused header includes
It doesn't really makes sense to return a size_t here.
daljit46
force-pushed
the
slim_mrtrix_stats_headers
branch
from
0faeec3 to
ff98d70
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves non-templated function definitions to source files from
core/mrtrix.handcore/stats.h. It also removes directly unused header includes in those files.Since these are core header files included in many files, this should improve (at least a little bit) compile times.