Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI clang-tidy review action #2873

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix CI clang-tidy review action #2873

merged 1 commit into from
Apr 9, 2024

Conversation

daljit46
Copy link
Member

@daljit46 daljit46 commented Apr 8, 2024

Aims to fix the running of the clang-tidy review action. The issue was encountered in #2865 and #2871.
Error message:

CMake Warning at core/CMakeLists.txt:79 (message):
libpng not found, disabling PNG support
CMake Warning at core/CMakeLists.txt:86 (message):
libtiff not found, disabling TIFF support
fatal: detected dubious ownership in repository at '/github/workspace'
To add an exception for this directory, call:
git config --global --add safe.directory /github/workspace
fatal: detected dubious ownership in repository at '/github/workspace'
To add an exception for this directory, call:
git config --global --add safe.directory /github/workspace
CMake Error at /github/workspace/cmake/FindVersion.cmake:21 (message):
MRtrix3 base version does not match the git tag!

Instead of generating the compilation database for compiler commands inside the container (as suggested by the documentation of the recipe of the action), we explictly run cmake . -DCMAKE_EXPORT_COMPILE_COMMANDS=ON prior to running ZedThree/clang-tidy-review.

@daljit46 daljit46 force-pushed the fix_clang_tidy_review branch from a9e90c3 to 7df79ed Compare April 8, 2024 10:46
Copy link

github-actions bot commented Apr 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@daljit46 daljit46 self-assigned this Apr 8, 2024
@daljit46 daljit46 marked this pull request as draft April 8, 2024 11:07
@daljit46 daljit46 marked this pull request as ready for review April 8, 2024 13:16
@daljit46 daljit46 merged commit 9677cd8 into dev Apr 9, 2024
6 checks passed
@daljit46 daljit46 deleted the fix_clang_tidy_review branch April 9, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant