Change member card prop

Maakaf · Mar 31, 2024 · 311c6c6 · 311c6c6
1 parent 6f8bb14
commit 311c6c6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 21 deletions.
diff --git a/components/Members/MemberCard/MemberCard.tsx b/components/Members/MemberCard/MemberCard.tsx
@@ -1,9 +1,9 @@
 import React from 'react';
 import { MemberCardInfo } from './MemberCardInfo';
 import { MemberCardSocialButtons } from './MemberCardSocialButtons';
-import { MemberCardInfoProps, MemberCardSocialsProps } from '../../../types';
+import { MemberCardInfoProps } from '../../../types';
 
-type MemberCardProps = MemberCardInfoProps & MemberCardSocialsProps;
+type MemberCardProps = MemberCardInfoProps;
 
 export const MemberCard = ({
   imgUrl,

diff --git a/components/Members/MemberCard/MemberCardSocialButtons.tsx b/components/Members/MemberCard/MemberCardSocialButtons.tsx
@@ -2,13 +2,18 @@ import React from 'react';
 import { TwitterMemberLink } from './socialIcons/TwiterMemberLink';
 import { LinkedInMemberLink } from './socialIcons/LinkedInMemberLink';
 import { GithubMemberLink } from './socialIcons/GithubMemberLink';
-import { MemberCardSocialsProps } from '@/types';
+
+interface MemberCardSocialButtonsProps {
+  linkedInUrl : string;
+  twitterUrl : string;
+  githubUrl : string;
+}
 
 export const MemberCardSocialButtons = ({
   linkedInUrl,
   twitterUrl,
   githubUrl,
-}: MemberCardSocialsProps) => {
+} : MemberCardSocialButtonsProps) => {
   return (
     <div className="flex flex-col w-[67px] bg-purple-200 justify-evenly dark:bg-gray-800 rounded-tl-2xl rounded-bl-2xl shadow-2xl">
       <LinkedInMemberLink linkedInUrl={linkedInUrl} />

diff --git a/types/index.ts b/types/index.ts
@@ -66,27 +66,17 @@ export interface Member {
   joinDate: string;
   isAdmin: boolean;
   linkedInUrl: string;
-  githubUrl: string;
   twitterUrl: string;
-}
-
-export interface MemberCardProps {
-  imgUrl: string;
-  name: string;
-  shortDescription: string;
-  longDescription: string;
-  joinDate: string;
-  isAdmin: boolean;
+  githubUrl: string;
 }
 
 export interface MemberCardInfoProps extends Omit<Member, 'id'> {}
 
-export interface MemberCardSocialsProps {
-  linkedInUrl: string;
-  twitterUrl: string;
-  githubUrl: string;
-}
-
 export interface MembersListProps {
-  members: Array<Member & MemberCardSocialsProps>;
+  members: Array<Member>;
 }
+
+export type MemberCardProps = Omit<
+  Member,
+  'id' | 'linkedInUrl' | 'githubUrl' | 'twitterUrl'
+>;