I18n - Translate to English #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noams24 is attempting to deploy a commit to a Personal Account owned by @Maakaf on Vercel. @Maakaf first needs to authorize it. |
Tamir198
reviewed
Mar 17, 2024
app/[locale]/page.tsx
Outdated
| const t = useTranslations('components.home'); | ||
|
|
||
| // const BeOurFriendsCards = [ | ||
| // { |
There was a problem hiding this comment.
If you dont use a code dont put it in a comment.
Delete it, you can always go back and check what this was before with git
| } | ||
|
|
||
| const HeaderItems = ({headerText}: any) => { | ||
| const pathname = usePathname(); |
There was a problem hiding this comment.
Please don't use any for the type.
Also, you can use restructuring for the component props
|
|
||
| interface HeaderItemsProps { | ||
| headerText: string[]; | ||
| } |
There was a problem hiding this comment.
This is not used, was your intention to replace the any (check below comment) type with HeaderItemsProps?
| @@ -1,5 +1,8 @@ | |||
| import { LINKS } from '@/config/consts'; | |||
| import Faqs from '../Common/Faqs'; | |||
| import { useTranslations } from 'next-intl'; | |||
|
|
|||
| // const t = useTranslations('maintainers'); | |||
|
|
|||
|
@Tamir198 Thanks for the review, I fixed what you said (there is still work to be done). |
|
Good work! |
Darkmift
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: