Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the member page style according to the Figma design #203

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

develad
Copy link
Contributor

@develad develad commented Mar 19, 2024

Hey everyone!

I've updated the member page style according to the Figma design and updated the images resource address, in the current published version the member image can't be loaded and there's a console error.

Also I left the font Birzia ( I think it's looking cooler ) and left the Discord link button on mobile view.

Check out the screen shots attached:

localhost_3001_he_members (1)

localhost_3001_he_members

localhost_3001_he_members(iPhone 14 Pro Max) (1)

Copy link

vercel bot commented Mar 19, 2024

@develad is attempting to deploy a commit to a Personal Account owned by @Maakaf on Vercel.

@Maakaf first needs to authorize it.

<p className="text-base ml-4">{name}</p>
{isAdmin && (
<Crown className="w-4 h-4 fill-[#4338CA] dark:fill-[#DBC927]" />
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we export this into a separate component? seems like something that can be used in the future across the website

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tamir198

How about we export this into a separate component? seems like something that can be used in the future across the website

Fine by me :) you can export this into a separate component

@develad develad force-pushed the member-page branch 2 times, most recently from b7b7885 to cf39689 Compare March 19, 2024 12:53
@Tamir198
Copy link
Contributor

Also, I thought it could be a cool feature to have a fallback image in case some user will lack a profile image.
what do you think?

@develad
Copy link
Contributor Author

develad commented Mar 19, 2024

@Tamir198

Also, I thought it could be a cool feature to have a fallback image in case some user will lack a profile image. what do you think?

Yes! It's a great idea. can you implement this feature? if you work on my files please pull the latest changes from my 'member-page' branch

@Tamir198
Copy link
Contributor

I don`t mind working on it but lets wait and merge this pr first to avoid conflicts

@Darkmift Darkmift merged commit c0a02db into Maakaf:main Mar 21, 2024
3 of 4 checks passed
@develad
Copy link
Contributor Author

develad commented Mar 21, 2024

@Darkmift
Thank you for the merge! I'm happy to contribute to this on going project

@develad develad mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants