Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controlling the member card style using the use TextDirection hook #254

Closed
wants to merge 1 commit into from
Closed

Controlling the member card style using the use TextDirection hook #254

wants to merge 1 commit into from

Conversation

develad
Copy link
Contributor

@develad develad commented Apr 4, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maakaf-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 9:46am

@develad develad closed this Apr 4, 2024
@develad develad deleted the 252-memebr-page-breaks-when-website-is-in-english branch April 4, 2024 09:46
@develad develad restored the 252-memebr-page-breaks-when-website-is-in-english branch April 4, 2024 09:47
@develad develad reopened this Apr 4, 2024
@develad
Copy link
Contributor Author

develad commented Apr 4, 2024

Hi @Tamir198
About #252 I know you opened a PR #253 but please check this implementation and tell me what you think?

develad
develad commented Apr 4, 2024
View reviewed changes
app/[locale]/not-found.tsx
@@ -13,7 +13,7 @@ export default function NotFound() {
<p>{t('paragraph')}</p>
<Link
href={LINKS.HOME}
className="w-[250px] my-8 text-xs discord-btn rounded-full px-7 py-2 flex items-start justify-center gap-2 dark:hover:bg-purple-200 item-hover-transition items-center"
className="w-[250px] my-8 text-xs discord-btn rounded-full px-7 py-2 flex justify-center gap-2 dark:hover:bg-purple-200 item-hover-transition items-center"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing redundant class to clear problem from the the terminal

@develad
Copy link
Contributor Author

develad commented Apr 4, 2024

This PR was merge into PR #250

@develad develad closed this Apr 4, 2024
@Tamir198
Copy link
Contributor

Tamir198 commented Apr 4, 2024

@develad

Generally, this would be the better solution, but for this case where the direction should be the same regardless of the language, in my opinion, it's a bit overkill.

@develad
Copy link
Contributor Author

develad commented Apr 4, 2024

@develad

Generally, this would be the better solution, but for this case where the direction should be the same regardless of the language, in my opinion, it's a bit overkill.

@Tamir198

Why does the 'direction should be the same regardless of the language' ???
It doesn't specified in the Figma design. Only the Hebrew version of the card is specified and it is only logical that the English version would be the other way around.

@Tamir198
Copy link
Contributor

Tamir198 commented Apr 4, 2024

@develad
Generally, this would be the better solution, but for this case where the direction should be the same regardless of the language, in my opinion, it's a bit overkill.

@Tamir198

Why does the 'direction should be the same regardless of the language' ??? It doesn't specified in the Figma design. Only the Hebrew version of the card is specified and it is only logical that the English version would be the other way around.

I guess you can say it, I was thinking that it should be displayed like this because of the figma (which as you mentioned doesn't specify the English version).
Can you add a screenshot of how it looks?

@develad
Copy link
Contributor Author

develad commented Apr 4, 2024

@develad
Generally, this would be the better solution, but for this case where the direction should be the same regardless of the language, in my opinion, it's a bit overkill.

@Tamir198
Why does the 'direction should be the same regardless of the language' ??? It doesn't specified in the Figma design. Only the Hebrew version of the card is specified and it is only logical that the English version would be the other way around.

I guess you can say it, I was thinking that it should be displayed like this because of the figma (which as you mentioned doesn't specify the English version). Can you add a screenshot of how it looks?

You can see the Preview in the visit preview from #250. I merged all the code to one PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@develad @Tamir198