-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom http headers #93
Open
benvolioT
wants to merge
10
commits into
MacPaw:main
Choose a base branch
from
benvolioT:custom-http-headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4f0342b
Add support for arbitrary HTTP headers to enable proxies like Helicon…
benvolioT b882637
Separate the client configuration and request headers construction so…
benvolioT 2334b8c
Mark generateHeaders() private to limit visibility, since it should o…
benvolioT 31532cc
Change private to internal for generateHeaders() visbility modifier t…
benvolioT bafdc53
Remove print() statement accidentally left in from debugging.
benvolioT e2d5dfa
Refactor to reduce cognitive complexity.
benvolioT 9413cce
Feat: Get token usage data for streamed chat completion response.
sdimka 52fe792
Add new chat models.
benvolioT e3bb727
Merge upstream, preserving change for custom http headers.
benvolioT b874f2d
Merge pull request #1 from sdimka/feature
benvolioT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// | ||
// BaseRequest.swift | ||
// | ||
// | ||
// Created by Benjamin Truitt on 7/28/23. | ||
// | ||
|
||
import Foundation | ||
#if canImport(FoundationNetworking) | ||
import FoundationNetworking | ||
#endif | ||
|
||
protocol RequestBuildable { | ||
var url: URL { get } | ||
var headers: [String: String] { get } | ||
var method: String { get } | ||
var timeoutInterval: TimeInterval { get } | ||
|
||
func getBody() throws -> Data? | ||
} | ||
|
||
protocol BaseRequest: RequestBuildable { | ||
func build() throws -> URLRequest | ||
} | ||
|
||
extension BaseRequest { | ||
func build() throws -> URLRequest { | ||
var request = URLRequest(url: url, timeoutInterval: timeoutInterval) | ||
|
||
request.httpMethod = method | ||
request.httpBody = try getBody() | ||
request.allHTTPHeaderFields = headers | ||
|
||
return request | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// | ||
// Empty.swift | ||
// | ||
// | ||
// Created by Benjamin Truitt on 7/29/23. | ||
// | ||
|
||
import Foundation | ||
|
||
struct Empty: Encodable { | ||
func encode(to encoder: Encoder) throws { | ||
// Do nothing | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the naming to
defaultHeaders
to add the knowledge that it is going to be appended further.What do you think?