Allow different implementations for server versions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-different-implementations-for-server-versions
Merged
…nt-different-implementations-for-server-versions
…-for-server-versions # Conflicts: # electron/providers/jira-server-provider/JiraServerProvider.ts # electron/providers/jira-server-provider/server-types.ts
aymka
requested changes
Dec 6, 2023
| reject(new Error(`Error in fetching labels: ${JSON.stringify(error)}`)) | ||
| ) | ||
| }) | ||
| throw new Error("Method not implemented for Jira Server") |
There was a problem hiding this comment.
getLabels() not implemented in this version and throws error
aymka
approved these changes
Dec 6, 2023
maximilianruesch
deleted the
refactor/implement-different-implementations-for-server-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to create different implementations for different server versions. Also gives an example implementation for an API endpoint that changed.