Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rare shader compilation error #4755

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Fix rare shader compilation error #4755

merged 4 commits into from
Feb 7, 2025

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jan 25, 2025 •
edited
Loading

Description

Fixes https://discourse.julialang.org/t/glmakie-loaderror-when-plotting-contour/124424

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Jan 25, 2025 •
edited
Loading

Benchmark Results

SHA: a1ba3c2728eb9f8b166b33d0d59f742031c902ee

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer
Copy link
Collaborator Author

ffreyer commented Feb 4, 2025

Fixes #4765

@ffreyer ffreyer changed the title Fix rare (shader) compilation error Fix rare shader compilation error Feb 4, 2025
@Semptum
Copy link

Semptum commented Feb 4, 2025

Fixes #4765

Confirmed

@ffreyer ffreyer merged commit 3510b23 into master Feb 7, 2025
22 checks passed
@ffreyer ffreyer deleted the ff/fix-shader-compile branch February 7, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonDanisch SimonDanisch SimonDanisch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR review
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffreyer @MakieBot @Semptum @SimonDanisch