Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify own config file #136

Merged
merged 14 commits into from
Mar 18, 2024
Merged

Conversation

ammarcsj
Copy link
Member

Minor change so user can provide their own .yaml to specify which files to support

@jalew188
Copy link
Collaborator

Hi @ammarcsj , I think it is better to add PR to development branch

@GeorgWa
Copy link
Collaborator

GeorgWa commented Feb 20, 2024

I missed the PR, will take a look tomorrow.

@ammarcsj ammarcsj changed the base branch from main to development February 21, 2024 13:32
@ammarcsj
Copy link
Member Author

ammarcsj commented Feb 21, 2024

Indeed I changed the base to development, as it is also not urgent

@GeorgWa
Copy link
Collaborator

GeorgWa commented Mar 3, 2024

Looks good to me @ammarcsj 👍🏻
Can you run nbdev_clean once and then we can merge?

Sorry for the delay 🤦🏻 😄

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ammarcsj
Copy link
Member Author

ammarcsj commented Mar 15, 2024

thanks for checking, nbs are cleaned now

@GeorgWa GeorgWa merged commit bdc9877 into development Mar 18, 2024
8 checks passed
@GeorgWa GeorgWa deleted the alphaquant_updates branch March 18, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants