Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpecLlibFlat to specLibBase conversion #138

Merged
merged 4 commits into from
Mar 8, 2024
Merged

SpecLlibFlat to specLibBase conversion #138

merged 4 commits into from
Mar 8, 2024

Conversation

mo-sameh
Copy link
Collaborator

@mo-sameh mo-sameh commented Mar 4, 2024

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@GeorgWa
Copy link
Collaborator

GeorgWa commented Mar 5, 2024 •
edited
Loading

  1. when inferring charged frag types, include all charges up to the maximum observed charge.
  2. Move all test cases into a single notebook at spectral_library/flat_library.ipynb
  3. run nbdev_clean
  4. Update remove unused to use available_fragment_dfs() as source of dense fragments df

Then we are ready to merge 🚀

@mo-sameh mo-sameh marked this pull request as ready for review March 8, 2024 16:40
@GeorgWa GeorgWa merged commit 578b056 into development Mar 8, 2024
8 checks passed
@GeorgWa GeorgWa deleted the SpecLibFlat-to-SpecLibBase branch March 8, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mo-sameh @GeorgWa