rename diann spec_idx to diann_spec_idx #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Fix #143 ? |
GeorgWa
approved these changes
Mar 14, 2024
|
Hi Feng, looks good 👍 what is the origin of that bug? Is it Pandas? Just to make sure that I understand it if it happens to me. |
Hi @GeorgWa, from the auto tests, I guess it is due to pandas version and only on Linux. I think all iloc.values will be a readonly property instead of a ref of numpy array. I am not entirely sure anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pandas upgrade, some df.values will be readonly in Linux. This PR is designed to fix some read-only issues.