Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve requirements #59

Merged
merged 11 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nbdev_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
shell: bash -le {0}
run: |
cd misc
. ./loose_pip_install.sh
. ./pip_install.sh loose,tests

- name: Unittests
shell: bash -le {0}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/quick_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
shell: bash -le {0}
run: |
cd misc
. ./stable_pip_install.sh
. ./pip_install.sh stable,tests
- name: Run pipeline
shell: bash -le {0}
run: |
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
shell: bash -le {0}
run: |
cd misc
. ./loose_pip_install.sh
. ./pip_install.sh loose,tests
- name: Run pipeline
shell: bash -le {0}
run: |
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/quick_tests_ubuntu.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
on:
push:
branches: [ main, development ]
# branches: [ main, development ]
# TODO: this is covered already by quick_tests.yml
pull_request:
workflow_dispatch:

Expand All @@ -27,7 +28,7 @@ jobs:
shell: bash -le {0}
run: |
cd misc
. ./stable_pip_install.sh
. ./pip_install.sh stable,tests

- name: Unittests
shell: bash -le {0}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ratio_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
shell: bash -le {0}
run: |
cd misc
. ./stable_pip_install.sh
. ./pip_install.sh stable,tests

- name: Ratio tests
shell: bash -le {0}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unused/all_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
shell: bash -le {0}
run: |
cd misc
. ./loose_pip_install.sh
. ./pip_install.sh loose,tests
- name: Unittests
shell: bash -le {0}
run: |
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ directLFQ is started internally via the directlfq.lfq_manager.run_lfq() command.
- **num_cores**: The number of cores to use (default is to use multiprocessing).
- **filename_suffix**: Suffix to append to the output files.
- **deactivate_normalization**: Set to true, if no between-sample normalization should be performed before processing.
- **filter_dict**: In case you want to define specific filters in addition to the standard filters, you can add a yaml file where the filters are defined (see example [here](release/examples/filterdict.yaml)). In the Python API you can also directly put in the dictionary instead of the .yaml file.
- **filter_dict**: In case you want to define specific filters in addition to the standard filters, you can add a yaml file where the filters are defined (see example [here](misc/examples/filterdict.yaml)). In the Python API you can also directly put in the dictionary instead of the .yaml file.

---

Expand Down
File renamed without changes.
5 changes: 0 additions & 5 deletions misc/loose_pip_install.sh

This file was deleted.

25 changes: 25 additions & 0 deletions misc/pip_install.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
#!/bin/bash
### Install the package with a given type in a defined conda environment with a define python version,
### and call it to check if it works
### example usage:
### ./pip_install.sh stable my_env 3.9
set -e -u

INSTALL_TYPE=$1 # stable, loose, etc..
ENV_NAME=${2:-directlfq}
PYTHON_VERSION=${3:-3.9}

conda create -n $ENV_NAME python=$PYTHON_VERSION -y

if [ "$INSTALL_TYPE" = "loose" ]; then
INSTALL_STRING=""
else
INSTALL_STRING="[${INSTALL_TYPE}]"
fi

# print pip environment for reproducibility
conda run -n $ENV_NAME --no-capture-output pip freeze

# conda 'run' vs. 'activate', cf. https://stackoverflow.com/a/72395091
conda run -n $ENV_NAME --no-capture-output pip install -e "../.$INSTALL_STRING"
conda run -n $ENV_NAME --no-capture-output directlfq
5 changes: 0 additions & 5 deletions misc/stable_pip_install.sh

This file was deleted.

3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ dependencies = {file = ["requirements/requirements_loose.txt"]}
optional-dependencies = { stable = { file = ["requirements/requirements.txt",
] }, gui = { file = [ "requirements/requirements_gui_loose.txt",
] }, gui-stable = { file = [ "requirements/requirements_gui.txt",
] }, development = { file = ["requirements/requirements_development.txt"
] }, tests = { file = [ "requirements/requirements_tests.txt",
] }, development = { file = ["requirements/requirements_development.txt", "requirements/requirements_tests.txt",
] }}

version = {attr = "directlfq.__version__"}
Expand Down
1 change: 0 additions & 1 deletion release/windows/build_installer_windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,3 @@ pip install "dist/$WHL_NAME[stable,gui-stable]"
# Creating the stand-alone pyinstaller folder
pip install pyinstaller
pyinstaller release/pyinstaller/directlfq.spec --distpath dist_pyinstaller --workpath build_pyinstaller -y
# pip install jinja2==3.0
7 changes: 2 additions & 5 deletions requirements/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
# Dependencies required for running the "stable" version of directlfq.
# Only usage of fixed versions is allowed, and all dependencies listed here must also be
# included in `requirements_loose.txt` (enforced by a test).
Jinja2==3.1.2
numpy==1.23.5
pandas>=1.5.3 # test: tolerate_version
dask>=2023.1.0 # test: tolerate_version
pandas==2.2.3
dask==2024.8.0
numba==0.56.4
multiprocess==0.70.14
wget==3.2
PyYAML==6.0.2
pyarrow==17.0.0
15 changes: 2 additions & 13 deletions requirements/requirements_development.txt
Original file line number Diff line number Diff line change
@@ -1,20 +1,9 @@
# Dependencies helping for development
jupyter
jupyter_contrib_nbextensions
pyinstaller
autodocsumm
sphinx-rtd-theme
twine
bump-my-version
pipdeptree
ipykernel
tqdm
psutil
matplotlib_venn
wget
seaborn
matplotlib
nbdev>=2.3.9
notebook
alphabase>=1.4.0
progressbar
pytest
notebook
3 changes: 0 additions & 3 deletions requirements/requirements_loose.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
# Dependencies required for running the "loose" version of direclfq.
# All dependencies that are also included in `requirements.txt` must be added also here (enforced by a test).
Jinja2
numpy
pandas
dask
numba
multiprocess
wget
PyYAML
pyarrow
9 changes: 9 additions & 0 deletions requirements/requirements_tests.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Dependencies required for running tests
matplotlib_venn
matplotlib
wget
seaborn
nbdev>=2.3.9
alphabase>=1.4.0
progressbar
pytest
Loading