Merge frame splitting into sw dev #23
Conversation
…r defaults for dia data
tests/spectrum_readers.rs
Outdated
| .get_all() | ||
| .unwrap(); | ||
|
|
||
| println!(">>>>> UNIFORM {} > {:?}", i, frames.len()); |
There was a problem hiding this comment.
I would maybe remove this ugly set of prints ... but other than that LGTM! the history seems to be preserved as far as I can tell ...
|
I can tidy those prints in the next PR if that is OK with you! lmk if you want a cascading PR onto this one or to use dev as a new base once we merge this one (to add the default options + splitting in terms of 1/k0 instead of scans). and feel free to merge whenever. |
|
I removed print statements and merged into develop. The default are reasonably set at the moment (I introduced builders for SpectrumReaders and PrecursorReaders, whereas I resctructed code so FrameReader is untouched as our changes where only at the SpectrumLevel). Future implementations to split in terms of 1/k0 instead of scans are best made on a new branch of develop. We also will need to make a new Sage PR of course to propagate the config info to timsrust from there. I am happy to look into that, good excercise for me as I havent worked much with serde yet:) |
No description provided.