Skip to content

MDEV-30831 fixing, aws_key_management can compile with new aws sdk on UBUNTU 22.04, 24.04 #4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 10.11
Choose a base branch
from

Conversation

csenki
Copy link

@csenki csenki commented Apr 28, 2025

  • *The Jira issue number for this PR is: MDEV-30831

Description

MDEV-30831 fixing, aws_key_management plugin can compile with new aws sdk on UBUNTU 24.04 and 22.04
Its fix working with mariadb-10.11.

Release Notes

Little changes, only change 2 CMakeLists.txt and some include added to aws_key_management_plugin.cc

How can this PR be tested?

I tested build process.
cmake ../mariadb-serever -DPLUGIN_AWS_KEY_MANAGEMENT=DYNAMIC -DAWS_SDK_EXTERNAL_PROJECT=1 -DNOT_FOR_DISTRIBUTION=1
cd plugin/aws_key_management
make
I tested the plugin:
Install plugin
alter table .... ENGINE=INNODB encrypted=yes;
alter table .... ENGINE=INNODB encrypted=no;
I tested mariadb start and stop.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@csenki csenki mentioned this pull request Apr 28, 2025
5 tasks
@svoj svoj added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Apr 28, 2025
@svoj svoj requested a review from vaintroub April 28, 2025 06:33
@ottok
Copy link
Contributor

ottok commented May 1, 2025

Thanks for updating the submission based on feedback!

As your new commit 0d6beef modifies your own previous commit, it might be better to just amend the first commit instead of adding a new one. The end result of this PR should most likely be just one commit that fixes the build issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements.
Development

Successfully merging this pull request may close these issues.

4 participants