Add timeout settings to HTTP requests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timeout settings to all HTTP requests made to Obsidian Local REST API to prevent potential freezes when the API becomes unresponsive.
Background
There is a known issue with Obsidian Local REST API where it sometimes does not return a response when encountering errors (see coddingtonbear/obsidian-local-rest-api#139). While there might be other cases where error handling is insufficient in the API, this PR focuses on preventing indefinite freezes by adding proper timeout handling.
Changes
(3, 6)(connect timeout, read timeout) to all HTTP requestsThe client now fails gracefully with timeout errors instead of hanging indefinitely, and errors occur before MCP clients would disconnect.
This PR resolves #3.