Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: enhanced homepage #75

Closed

Conversation

Yatin12527
Copy link

Fixed #65
Hey as promised I tried to improve the overall look of homepage by incorporating images and trying new style to design the display.
I tried to stay faithful to the blue and white color theme as much as it was possible with the current design.
I left the buttons hover effects as it is as I only asked for changing design patter but I'm more than happy to add or subtract from this design as you might like.
Here's before vs after comparison:-

Before
image

After

2024-01-06.00-15-48.1.mp4

Also the lag in recording is some glitch in my system I don't know why it does that.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on creating your first pull request! Thank you so much for contributing to Minglr.

@Mayuresh-22
Copy link
Owner

Mayuresh-22 commented Jan 6, 2024

That's looking awesome @Yatin12527 🤗. Congratulations on creating your first pull request!
I tested it on my machine and found the design is not responsive. Have look into it.

@Mayuresh-22 Mayuresh-22 added SWOC S4 Issues with this labels are officially for Social Winter of Code program HARD Issues with this labels has HARD level difficulty SWOC S4 Accepted and removed SWOC S4 Accepted labels Jan 6, 2024
@Yatin12527
Copy link
Author

Yatin12527 commented Jan 6, 2024

That's looking awesome @Yatin12527 🤗. Congratulations on creating your first pull request! I tested it on my machine and found the design is not responsive. Have look into it.

Hey mayuresh I'm glad u liked the design but I'm not rly good at creating responsive designs i might end up making it worse so if u still wanna give the issue to me then i can try but it'd be better if someone who knows it better does it :)

@Yatin12527 Yatin12527 closed this Jan 6, 2024
@Yatin12527 Yatin12527 reopened this Jan 6, 2024
@1-ankush-1
Copy link
Contributor

That's looking awesome @Yatin12527 🤗. Congratulations on creating your first pull request! I tested it on my machine and found the design is not responsive. Have look into it.

Hey mayuresh I'm glad u liked the design but I'm not rly good at creating responsive designs i might end up making it worse so if u still wanna give the issue to me then i can try but it'd be better if someone who knows it better does it :)

Approch to solve - @Yatin12527 try this approch

  • use media queries . on smaller screen hide the left side which is image ex- just give that image a classname and make add display none on small screen.

Hey @Mayuresh-22 if @Yatin12527 will not be able to solve it i will be happy to take this issue.

@Yatin12527
Copy link
Author

That's looking awesome @Yatin12527 🤗. Congratulations on creating your first pull request! I tested it on my machine and found the design is not responsive. Have look into it.

Hey mayuresh I'm glad u liked the design but I'm not rly good at creating responsive designs i might end up making it worse so if u still wanna give the issue to me then i can try but it'd be better if someone who knows it better does it :)

Approch to solve - @Yatin12527 try this approch

  • use media queries . on smaller screen hide the left side which is image ex- just give that image a classname and make add display none on small screen.

Hey @Mayuresh-22 if @Yatin12527 will not be able to solve it i will be happy to take this issue.
Ik how the issue might be fixed using media queries but i've not worked enough on responsive designs to take on this work is all i'm saying and i'll be happy to share the issue with u :)

@Mayuresh-22
Copy link
Owner

Okay then, do you want to continue working on this issue @1-ankush-1?

@1-ankush-1
Copy link
Contributor

Okay then, do you want to continue working on this issue @1-ankush-1?

I can make it responsive.
you can assign this to me.

@Mayuresh-22
Copy link
Owner

Mayuresh-22 commented Jan 8, 2024

@1-ankush-1 I am assigning it to you... comment on #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HARD Issues with this labels has HARD level difficulty SWOC S4 Issues with this labels are officially for Social Winter of Code program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Enhance the homepage
3 participants