Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Confirmation Logout Pop Up #96

Closed
wants to merge 0 commits into from

Conversation

Amine2000s
Copy link
Contributor

@Amine2000s Amine2000s commented Jan 22, 2024

solved #61
Confiramtion_logout_on_message
confirmation_logout_on_about_us
confirmation_logout_on_feed
confirmation_logout_on_account

@Mayuresh-22
Copy link
Owner

CodeFactor found multiple issues last seen at cc363b7:

Unexpected duplicate "display" (declaration-block-no-duplicate-properties)

Unexpected duplicate "border" (declaration-block-no-duplicate-properties)

Unexpected duplicate "padding" (declaration-block-no-duplicate-properties)

Unexpected duplicate "background-color" (declaration-block-no-duplicate-properties)

@Amine2000s
Copy link
Contributor Author

Amine2000s commented Jan 23, 2024

@Mayuresh-22 everything is fixed
And ready to merge

@Mayuresh-22
Copy link
Owner

Hey @ Amine2000s, you have done a great job. But I saw you removed the password requirement JS code too. That's one of the important parts as the user gets the hint about the valid password they can use on Minglr. So please add it back so that it will again be a part of Minglr codebase.

@Mayuresh-22 Mayuresh-22 added enhancement New feature or request SWOC S4 Issues with this labels are officially for Social Winter of Code program MEDIUM Issues with this labels has medium level difficulty labels Jan 24, 2024
@Amine2000s
Copy link
Contributor Author

ohh! soory i forgot to get it back i will get it back

@Amine2000s
Copy link
Contributor Author

the js confiramtion logic is back @Mayuresh-22

@Amine2000s
Copy link
Contributor Author

the password hints is also returned @Mayuresh-22

@Mayuresh-22
Copy link
Owner

I see there isn't a password hint thing except everything is perfect
image

@Amine2000s
Copy link
Contributor Author

Password_hint

i meant this area of code , which i thought that is was kind of like a password "hint" to help user create a password with the specified rules

@Mayuresh-22
Copy link
Owner

Password_hint

i meant this area of code , which i thought that is was kind of like a password "hint" to help user create a password with the specified rules
Yes, you are correct. However, JS code triggers the above code block to appear.
I'll suggest you to create new branch from Minglr's repo and then migrate your confirmation popup changes to it.

@Amine2000s
Copy link
Contributor Author

@Mayuresh-22 i don't understand , you mean to fork a new repo , or do you mean create a new branch from my own actual fork? Otherwise, otherwise i can't create a new branch from the official Minglr repo

@Amine2000s
Copy link
Contributor Author

@Mayuresh-22 hello ?

@Mayuresh-22
Copy link
Owner

New PR with same title at #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MEDIUM Issues with this labels has medium level difficulty SWOC S4 Issues with this labels are officially for Social Winter of Code program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants