-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Confirmation Logout Pop Up #96
Conversation
CodeFactor found multiple issues last seen at cc363b7: Unexpected duplicate "display" (declaration-block-no-duplicate-properties)Unexpected duplicate "border" (declaration-block-no-duplicate-properties)Unexpected duplicate "padding" (declaration-block-no-duplicate-properties)Unexpected duplicate "background-color" (declaration-block-no-duplicate-properties) |
@Mayuresh-22 everything is fixed |
Hey @ Amine2000s, you have done a great job. But I saw you removed the password requirement JS code too. That's one of the important parts as the user gets the hint about the valid password they can use on Minglr. So please add it back so that it will again be a part of Minglr codebase. |
ohh! soory i forgot to get it back i will get it back |
the js confiramtion logic is back @Mayuresh-22 |
the password hints is also returned @Mayuresh-22 |
|
@Mayuresh-22 i don't understand , you mean to fork a new repo , or do you mean create a new branch from my own actual fork? Otherwise, otherwise i can't create a new branch from the official Minglr repo |
@Mayuresh-22 hello ? |
New PR with same title at #103 |
solved #61
![Confiramtion_logout_on_message](https://private-user-images.githubusercontent.com/92222814/298569547-108c8373-cb91-4c1c-8d1b-c14ac1a609b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTM5NjMsIm5iZiI6MTczODg5MzY2MywicGF0aCI6Ii85MjIyMjgxNC8yOTg1Njk1NDctMTA4YzgzNzMtY2I5MS00YzFjLThkMWItYzE0YWMxYTYwOWI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDAyMDEwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4YzZiMjYzZWJkMzU4OGEwMGM3NGVlYjNiMzQ1OGI2YzFmNDU0MDAzNWVmMWE2MTRlYjgxZWJhZWQ2NDVlMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.GxacRJxCOJPNn8ZIFjHBOKzsvi8QJa41hokm5MgyKSw)
![confirmation_logout_on_about_us](https://private-user-images.githubusercontent.com/92222814/298569566-16720cff-00fe-4e78-b8ea-b35d349e1b16.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTM5NjMsIm5iZiI6MTczODg5MzY2MywicGF0aCI6Ii85MjIyMjgxNC8yOTg1Njk1NjYtMTY3MjBjZmYtMDBmZS00ZTc4LWI4ZWEtYjM1ZDM0OWUxYjE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDAyMDEwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZmZWUyZjc2MDcwOThiMTQwYzFkNGMzNWEwZTE3ZGI0YzY1ZDc4YmQ2ZDMxNjQxZjExYjc1NTYxNGRiOGM0MDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.t_frspAJ-S8bzaskg8IN_A4MnLEiXlcVZkaa72L2SUg)
![confirmation_logout_on_feed](https://private-user-images.githubusercontent.com/92222814/298569597-17b6f98f-fe91-47fb-9c77-c4fc7f9cff4f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTM5NjMsIm5iZiI6MTczODg5MzY2MywicGF0aCI6Ii85MjIyMjgxNC8yOTg1Njk1OTctMTdiNmY5OGYtZmU5MS00N2ZiLTljNzctYzRmYzdmOWNmZjRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDAyMDEwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwYWY3ZjFhOTQwOTQwYTE5MWVmOTc2YjRhYWZiODJkM2U5MWFkNzlkNTgxMzc3ZjYwZjhiNDNlN2VmZjc0NGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.WFdFEITJVG7KStujjiBTB7Cv91tkyDfDG_7ryaNJbLo)
![confirmation_logout_on_account](https://private-user-images.githubusercontent.com/92222814/298569618-796b32c3-a236-4c42-b4d0-86d55246709f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTM5NjMsIm5iZiI6MTczODg5MzY2MywicGF0aCI6Ii85MjIyMjgxNC8yOTg1Njk2MTgtNzk2YjMyYzMtYTIzNi00YzQyLWI0ZDAtODZkNTUyNDY3MDlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDAyMDEwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZmMTlhOGRlZjJhZmI1ZWUxYzk0OWJmY2I1NzViYjY3MjI2Mzc2ZDYxYTE2ZWYyNzRhMjkwMWViNjc2ZmNkODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xkGoJ6IS9BoUDHB3U1cT7k0o77sZrOkR-TnZtUiT5T8)