Skip to content

Commit

Permalink
Allow get zcopy for smallest sizes
Browse files Browse the repository at this point in the history
  • Loading branch information
tvegas1 committed May 23, 2024
1 parent 5b4b4c1 commit 2d0f76c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 1 addition & 2 deletions .ci/run_nccl_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ MPIRUN_OPTIONS_COMMON="\
-x UCX_MEMTYPE_CACHE=n \
-x HCOLL_ENABLE_SHARP=0 \
-x HCOLL_ENABLE_MCAST_ALL=0 \
-x UCX_RC_MLX5_TX_INLINE_RESP=0 \
-mca pml ucx \
-mca coll_hcoll_enable 1 \
--map-by node \
Expand Down Expand Up @@ -110,7 +109,7 @@ for TEST_EXE in ${NCCL_TEST_EXE[@]}; do
#===================
# Enable ucx_rma tests once this is resolved: https://redmine.mellanox.com/issues/3037941
# for P2P_LAYER in ucx ucx_rma ib
for P2P_LAYER in ucx_uct_read ib ucx_uct ucx; do
for P2P_LAYER in ib ucx ucx_uct ucx_uct_read; do
MPIRUN_OPTIONS_PLUGIN_P2P_LAYER="-x NCCL_PLUGIN_P2P=${P2P_LAYER}"

#===================
Expand Down
6 changes: 6 additions & 0 deletions src/ucx_uct_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ static uct_iface_h nccl_uct_resource_iface_open(uct_worker_h worker,
UCXCHECK(uct_md_iface_config_read(md, tl->tl_name, NULL, NULL, &config),
return NULL, "read MD iface config for TL '%s'", tl->tl_name);

if (uct_config_modify(config, "RC_MLX5_TX_INLINE_RESP", "0") != UCS_OK) {
WARN("Failed to modify MD configuration for '%s'", tl->tl_name);
uct_config_release(config);
return NULL;
}

params.field_mask =
UCT_IFACE_PARAM_FIELD_OPEN_MODE | UCT_IFACE_PARAM_FIELD_DEVICE |
UCT_IFACE_PARAM_FIELD_STATS_ROOT | UCT_IFACE_PARAM_FIELD_RX_HEADROOM;
Expand Down

0 comments on commit 2d0f76c

Please sign in to comment.