Disable metrics and health checks ports in config daemon #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11345856770Details
💛 - Coveralls |
We don't use metrics and health checks endpoints in the config daemon, and they use common 8080/8081 ports by default, which might be taken on a busy node. Since we have to use host network inside the pod, this might result in a crash loop while waiting for the port to free up The solution is to disable metrics and health checks until we need them Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
almaslennikov
force-pushed
the
fix-common-ports
branch
from
42dc22b to
ebd9c01
Compare
e0ne
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use metrics and health checks endpoints in the config daemon, and they use common 8080/8081 ports by default, which might be taken on a busy node. Since we have to use host network inside the pod, this might result in a crash loop while waiting for the port to free up
The solution is to disable metrics and health checks until we need them