Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue:3950870 PDR: send a reset REST API of a port after isolation #257

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

vg12345
Copy link
Contributor

@vg12345 vg12345 commented Sep 17, 2024

What

Send a reset REST API of a port after isolation

Testing ?

Manual simulated testing from sources

Special triggers

Use the following phrases as comments to trigger different runs

  • bot:retest rerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)
  • bot:upgrade run additional update tests

@vg12345 vg12345 requested review from TalLerner, drorlevy and egershonNvidia and removed request for TalLerner and drorlevy September 17, 2024 14:20
@egershonNvidia
Copy link
Contributor

why are you resetting a port after isolating it? it doesn't make sense

@vg12345 vg12345 marked this pull request as draft September 18, 2024 09:11
@vg12345
Copy link
Contributor Author

vg12345 commented Sep 18, 2024

Need to add (per port):
- Max number of resets
- Time interval after last reset that zeroes reset counter (reenables resets)

@vg12345
Copy link
Contributor Author

vg12345 commented Sep 19, 2024

bot:retest

@vg12345 vg12345 marked this pull request as ready for review September 19, 2024 09:22
Copy link
Contributor

@drorlevy drorlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! we need to add a test

@TalLerner TalLerner merged commit ec69bc2 into main Sep 19, 2024
2 checks passed
@vg12345 vg12345 deleted the vg-pdr-3950870 branch September 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants