issue: #4268945: Use class member instead of function call #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstr-nvidia
approved these changes
Jan 23, 2025
boazhaim
reviewed
Jan 23, 2025
| self._dataframes_for_pdf.append( | ||
| ( | ||
| f"{self.telemetry_type} telemetry iteration time", | ||
| self._iteration_time_stats(), | ||
| self._iteration_time_stats, |
There was a problem hiding this comment.
if we had a unit test for this, it would have catch it :)
boazhaim
approved these changes
Jan 23, 2025
TalLerner
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In ibdiagnet2_port_counters_analyzer.py, remove the brackets on line 200.
Why ?
Using brackets is incorrect since there’s no function being called. The code should reference the class member instead.
Additionally, rename the function from save_last_iterations_time_stats to save_iterations_time_stats, as it saves general iteration time statistics.
https://redmine.mellanox.com/issues/4268945
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests