issue:4273572 Add NDT plugin upgrade flow #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue:4274215 support duplicated node description report in case no other errors detected (bug fix) Signed-off-by: Alex Tabachnik <atabachnik@nvidia.com>
alextabachnik
requested review from
kobibar,
kedeme,
anasbadaha,
atolikin94,
shmufeld and
boazhaim
need for ci as it is not running as root Signed-off-by: Alex Tabachnik <atabachnik@nvidia.com>
|
bot:retest |
kedeme
changed the title
kedeme
reviewed
Feb 3, 2025
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
| # upgrade flow not implemented for NDT plugin | |||
There was a problem hiding this comment.
why not? don't we need to upgrade the NDT plugin configuration?
… master node (#291) * Making the script run on master * Fix condition for master/standby * ruff * Adding more info to the readme and renaming * updating the readme * readme * PR comments * PR comments
….sh upgrade command fails (#296)
…om multiple telemetry endpoints. (#293)
Signed-off-by: Alex Tabachnik <atabachnik@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:4274215 support duplicated node description report in case no other errors detected (bug fix)
What
implement upgrade.sh script that could be used for upgrade flow if need
handle option for merger report when node description duplication error is an only error in report (buf fix bug )
Why ?
Fix a bug and add functionality (upgrade)
How ?
Implemented empty upgrade.sh script as this script required by upgrade flow.
Added functionality for duplicated node description report if it is the only error in fabric
Testing ?
Tested manually
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests