Apis 1131 fix name connect issue in mac #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonjaSt
approved these changes
Jan 16, 2025
salman2135
added a commit
that referenced
this pull request
Jan 31, 2025
* change unstable bt threshold to .5s (#295) * Hotfix unstable imp (#296) * change unstable bt threshold to .5s * add hint for disabled BT * Hotfix unstable imp (#297) * change unstable bt threshold to .5s * add hint for disabled BT * apply changes for v3.1.0 * delete redundant files * add shared libraries * add .pyd file * add mac libraries * add files to public repo * fix flake8 error * apply isort * add files to public repo (#311) * add files to public repo * fix flake8 error * apply isort * Bump sentry-sdk from 1.19.1 to 2.8.0 in /docs (#304) Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.19.1 to 2.8.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@1.19.1...2.8.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Salman Rahman <salman2135@gmail.com> * Bump tornado from 6.3.2 to 6.4.1 in /docs (#303) Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.3.2 to 6.4.1. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.3.2...v6.4.1) --- updated-dependencies: - dependency-name: tornado dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Salman Rahman <salman2135@gmail.com> * delete shared lib * add byte calculator * update sentry sdk version to 2.8.0 (#314) * APIS-1081 Added testing for available EEG service in btcpp and unpair for OS other than Mac * APIS-1081 Changed call to get services, removed debug messages * APIS-1081 Removed reconnection attempts (on Maziar's recommendation) * APIS-1081 Removed execution of service discovery for MacOS * APIS-1081 Added async wait and replaced check for Mac with check for Windows * APIS-1081 Added UUID normalization, fixed linter * APIS-1081 Made wait only necessary for Windows, added checks to prevent getting new client and connecting if already done * Froze pylsl version to 1.16.2 (for now) * discard corrupt yaml file on load (#319) * discard corrupt yaml file on load * fix isort error * no reconnect on ble disconnection (#320) * no reconnect on ble disconnect * Set correct log messsage on disconnection callback * APIS-1036 Added Miniconda installation to macOS runner, updated upload action, updated Python version * Apis 930 reconnect problem at higher sampling rates (#317) * break parser loop on usb disconnect * APIS-1115 Replaced function to calculate notch coefficients with iirnotch * change baud rate & do sanity check on usb disconnect * read USB data in chunks * increase usb read timeout * check device name before usb connection (#318) * add comment * fix flake8 error * add whitespace before inline * read all available bytes from serial port in one go * wait 10ms in read method when data is not enough * set bt flag to false on usb * handle value error or recording stop * remove backslash from string * use lower order filter for higher SPS * add lock on data write * fix flake8 error * continue usb connection when name query fails * change core usb buffer to deque, add usb conditional in bt drop calc * restore debug message on usb read * APIS-930 Added catching yaml.parser.ParserError --------- Co-authored-by: SonjaSt <sonja.stefani@tum.de> * Apis 935 explore desktop loses track of impedance mode being enabled disabled (#321) * break parser loop on usb disconnect * APIS-1115 Replaced function to calculate notch coefficients with iirnotch * change baud rate & do sanity check on usb disconnect * read USB data in chunks * increase usb read timeout * check device name before usb connection (#318) * add comment * fix flake8 error * add whitespace before inline * read all available bytes from serial port in one go * wait 10ms in read method when data is not enough * set bt flag to false on usb * handle value error or recording stop * remove backslash from string * use lower order filter for higher SPS * add lock on data write * fix flake8 error * continue usb connection when name query fails * disable imp on fresh connection * check device info with specific key for imp mode * fix isort and flake8 errors --------- Co-authored-by: SonjaSt <sonja.stefani@tum.de> * Apis 1131 fix name connect issue in mac (#323) * stop stream and clear stream buffer before name query * remove unused method and import * remove print statement * isort fix * APIS-1131 Added lock to prevent simultaneous read/write to settings yaml * Linter (E302) settings_manager.py --------- Co-authored-by: SonjaSt <sonja.stefani@tum.de> * Froze bleak version (0.22.3) * Update tools.py (#325) * Bugfix command thread (#327) * move disable imp command on fresh connection to top level file * remove disable imp command from stream processor, update thread variable * separate notch filters for impedance (#326) * simplify-mac-intel-connection * Revert "simplify-mac-intel-connection" This reverts commit f2a1a86. * Remove acquiring serial port instance on BLE connect (#329) * remove acquiring serial port instance on BLE connect * APIS-1193 remove unused import for pr submission * Revert "APIS-1193 remove unused import for pr submission" This reverts commit 845b801. * APIS-1193 remove unused import for pr submission * Merge master into develop (#330) * Release 3.1.0 (#307) * change unstable bt threshold to .5s (#295) * Hotfix unstable imp (#296) * change unstable bt threshold to .5s * add hint for disabled BT * Hotfix unstable imp (#297) * change unstable bt threshold to .5s * add hint for disabled BT * apply changes for v3.1.0 * delete redundant files * add shared libraries * add .pyd file * add mac libraries * Updated the P300 oddball paradigm to work with Explore Pro devices (#310) * delete dynamic lib files --------- Co-authored-by: Kyotikk <63866051+Kyotikk@users.noreply.github.com> * delete dynamic lib files * Removed macOS from unit testing * Update docs (#333) * Added email to authors, removed duplicate section in stallation rst * Updated installation rst * Removed blueutil requirement for Mac * bumpversion minor * add changelog --------- Co-authored-by: Salman Rahman <salman2135@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nayan Sharma <51515645+rednayan@users.noreply.github.com> Co-authored-by: SonjaSt <sonja.stefani@tum.de> Co-authored-by: Sonja Stefani <35492857+SonjaSt@users.noreply.github.com> Co-authored-by: Kyotikk <63866051+Kyotikk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.