-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for pressure coordinate name variants plus enforce units to be hPa #1106
Conversation
Anne comment on why 'pressure_levels' is used: "It was just what was used in the rose-stem lfric output file and is also consistent with the global lfric suite. So not particularly chosen by us. If you can work with pressure_levels, then I'd be in favour of going with that, as I'm keen to be as consistent with other practices as possible." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach looks sensible, though there are a few coding things to improve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
LFRic has used another pressure coordinate name 'pressure_levels', plus there were some issues where domain pressure level spatial plots didn't work (and you wouldn't be able to diff UM and LFRic), given UM units were hPa and LFRic was Pa (and so the levels argument could not be used across models).
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.