Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rose edit and ancils guidance #319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add rose edit and ancils guidance #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/WorkingPractices/approvals.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ off the approval.
code owners is available and they should still be consulted as part of your
development.

.. important::

New UM Ancils must be submitted the the MIAO team for approval. Please follow their process for `Requesting New UM Ancils <https://code.metoffice.gov.uk/trac/ancil/wiki/ANTS/ProjectManagement/updating_UMDIR>`_.

Code Owners
-----------
Every file in the codebases has a :ref:`code_owner`, and every file changed
Expand Down
11 changes: 8 additions & 3 deletions source/WorkingPractices/inputs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Input Variables, Rose Metadata and Upgrade Macros
=================================================

.. important::

New UM Ancils must be submitted the the MIAO team for approval. Please follow their process for `Requesting New UM Ancils <https://code.metoffice.gov.uk/trac/ancil/wiki/ANTS/ProjectManagement/updating_UMDIR>`_.

Sometimes the developer needs to alter model namelists and input variables.
A common reason is for the inclusion of a new piece of code which has to be
turned off by default.
Expand Down Expand Up @@ -73,13 +78,13 @@ to the new metadata. The SSD team are also available to advise on whether an upg

rose edit -C rose-stem/app/APP-NAME

For LFRic Apps a few extra changes are required:
For LFRic Apps a few extra changes are required. In your branch (your test branch if you have an upgrade macro):

.. code-block::

export ROSE_PYTHONPATH=$PYTHONPATH
export ROSE_META_PATH=/path/to/valid/core
rose edit -C rose-stem/app/APP-NAME
export ROSE_META_PATH=/path/to/valid/core:/path/to/apps/copy
rose edit -C rose-stem/app/APP-NAME --no-warn version

This requires an LFRic Core working copy at an appropriate revision to be available. It is also necessary to run from the top level of the Apps working copy to ensure rose metadata paths are valid.

Expand Down
Loading