feat: remove KeyringSnapControllerClient to fix dependency problems (…

…#241) The `KeyringSnapControllerClient` class depends on the `SnapController` which adds a lot of dependencies to the `keyring-api`, causing circular dependency problems in other packages that depend on the `keyring-api`. The `KeyringSnapControllerClient` is currently used only by the `eth-snap-keyring` package, which is internal to MetaMask, so this change shouldn't break any other dependent code.
MetaMask · Jan 19, 2024 · 660e25f · 660e25f
1 parent 6c022b9
commit 660e25f
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 1,094 deletions.
diff --git a/package.json b/package.json
@@ -39,9 +39,7 @@
   },
   "dependencies": {
     "@metamask/providers": "^14.0.1",
-    "@metamask/snaps-controllers": "^4.0.0",
     "@metamask/snaps-sdk": "^1.3.2",
-    "@metamask/snaps-utils": "^5.1.2",
     "@metamask/utils": "^8.1.0",
     "@types/uuid": "^9.0.1",
     "superstruct": "^1.0.3",

diff --git a/src/KeyringSnapControllerClient.test.ts b/src/KeyringSnapControllerClient.test.ts
diff --git a/src/KeyringSnapControllerClient.ts b/src/KeyringSnapControllerClient.ts
diff --git a/src/index.ts b/src/index.ts
@@ -3,7 +3,6 @@ export * from './eth';
 export * from './events';
 export * from './internal';
 export * from './KeyringClient';
-export * from './KeyringSnapControllerClient';
 export * from './KeyringSnapRpcClient';
 export * from './rpc-handler';
 export * from './snap-utils';