feat: Add Redesign Permit support; fix: InfoRow padding and alignment #13369
Conversation
- baseline causes each row to have different centering - valueComponent flex-end caused elements to align bottom of row - missing gap between label and row value
digiwand
added
Run Smoke E2E
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
…efined -> toBeTruthy
| "label": { | ||
| "interacting_with": "Interacting with", | ||
| "spender": "Spender" | ||
| }, |
There was a problem hiding this comment.
most of the translation are label only, this grouping may not be very useful
There was a problem hiding this comment.
I think it's okay for organizational purposes
There was a problem hiding this comment.
NIT: It will be better to then move all labels into this.
| </InfoRow> | ||
| <View style={styles.dividerContainer}> | ||
| <InfoRowDivider /> | ||
| </View> |
There was a problem hiding this comment.
It will be better to be able to pass styles to divider row itself rather than wrap it in another view.
There was a problem hiding this comment.
I think it's better to avoid it in this case because the dividerContainer has these styles
dividerContainer: {
marginTop: 4,
marginBottom: 12,
},
for better reusability, it is better to keep outer margins and paddings separate. I think we can reconsider this once we have more cases using InfoRowDivider
| import Message from './Message'; | ||
| import TypedSignV3V4Simulation from './Simulation'; | ||
|
|
||
| const TypedSignV3V4 = () => ( | ||
| <> | ||
| <TypedSignV3V4Simulation /> | ||
| <InfoRowOrigin /> | ||
| <InfoSectionAddressAndOrigin /> |
There was a problem hiding this comment.
A more generic name name will be better in place of InfoSectionAddressAndOrigin. More fields may get added to this section and will be hard to keep changing the name for it.
There was a problem hiding this comment.
|
Description
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3919 (Permit support)
Fixes: #13368 (Permit Simulation value alignment)
Manual testing steps
https://develop.d3bkcslj57l47p.amplifyapp.com/ or https://metamask.github.io/test-dapp/
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist