Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

75 project overview page #105

Merged
merged 1 commit into from
Jul 26, 2024
Merged

75 project overview page #105

merged 1 commit into from
Jul 26, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Jul 19, 2024 •
edited by uittenbroekrobbert
Loading

Description

Describe in detail the changes you are proposing, and the rationale.

Link all GitHub issues fixed by this PR.
Make sure to first open an issue, get community approval and only then create Pull Request to resolve it.
All Pull Requests must have an issue attached to them

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog linked an issue Jul 19, 2024 that may be closed by this pull request
Project overview page #75
Closed
@berrydenhartog berrydenhartog force-pushed the 75-project-overview-page branch 10 times, most recently from cf0774d to e8344de Compare July 26, 2024 08:43
@berrydenhartog berrydenhartog marked this pull request as ready for review July 26, 2024 08:55
@berrydenhartog berrydenhartog requested a review from a team as a code owner July 26, 2024 08:55
@berrydenhartog berrydenhartog force-pushed the 75-project-overview-page branch from 1b35e7b to 0b3be02 Compare July 26, 2024 09:00
@berrydenhartog berrydenhartog force-pushed the 75-project-overview-page branch from 0b3be02 to d2aefb6 Compare July 26, 2024 09:38
uittenbroekrobbert
uittenbroekrobbert previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some minor remarks.

@berrydenhartog berrydenhartog force-pushed the 75-project-overview-page branch from d2aefb6 to 9eee3ee Compare July 26, 2024 11:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@berrydenhartog berrydenhartog enabled auto-merge July 26, 2024 11:23
@berrydenhartog berrydenhartog disabled auto-merge July 26, 2024 11:23
@berrydenhartog berrydenhartog enabled auto-merge July 26, 2024 11:23
@berrydenhartog berrydenhartog merged commit a08cb06 into main Jul 26, 2024
13 checks passed
@berrydenhartog berrydenhartog deleted the 75-project-overview-page branch July 26, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project overview page
2 participants
@berrydenhartog @uittenbroekrobbert