Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make status fields static instead of dynamic #111

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Make status fields static instead of dynamic #111

merged 1 commit into from
Jul 26, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Jul 25, 2024 •
edited
Loading

Description

Removes the dynamic status table and replaces it with a static set, updating all related components.

Resolves #94

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert linked an issue Jul 25, 2024 that may be closed by this pull request
Choice in number of columns #94
Closed
@uittenbroekrobbert uittenbroekrobbert force-pushed the 94-choice-in-number-of-columns branch 3 times, most recently from ba21327 to 7561812 Compare July 26, 2024 12:06
@uittenbroekrobbert uittenbroekrobbert marked this pull request as ready for review July 26, 2024 12:13
@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner July 26, 2024 12:13
@uittenbroekrobbert uittenbroekrobbert force-pushed the 94-choice-in-number-of-columns branch from 7561812 to 04f84d2 Compare July 26, 2024 12:15
@uittenbroekrobbert uittenbroekrobbert force-pushed the 94-choice-in-number-of-columns branch from 04f84d2 to ae498e4 Compare July 26, 2024 12:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

berrydenhartog
berrydenhartog approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berrydenhartog berrydenhartog merged commit 2c85449 into main Jul 26, 2024
14 checks passed
@berrydenhartog berrydenhartog deleted the 94-choice-in-number-of-columns branch July 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choice in number of columns
2 participants
@uittenbroekrobbert @berrydenhartog