Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

87 add csrf tokens to forms #114

Merged
merged 1 commit into from
Aug 6, 2024
Merged

87 add csrf tokens to forms #114

merged 1 commit into from
Aug 6, 2024

Conversation

ChristopherSpelt
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt commented Jul 29, 2024 •
edited
Loading

Add CSRF Tokens to projects/new post request

Adds CSRF protection via fastapi CSRF Token Protect (implementing double submit cookies) to the projects/new post request as a middleware layer.

Resolves #87

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ChristopherSpelt ChristopherSpelt linked an issue Jul 29, 2024 that may be closed by this pull request
Add CSRF tokens to forms #87
Closed
@ChristopherSpelt ChristopherSpelt force-pushed the 87-add-csrf-tokens-to-forms branch 3 times, most recently from f6c702e to c8c4270 Compare July 30, 2024 10:50
@ChristopherSpelt ChristopherSpelt marked this pull request as ready for review July 30, 2024 11:00
@ChristopherSpelt ChristopherSpelt requested a review from a team as a code owner July 30, 2024 11:00
berrydenhartog
berrydenhartog reviewed Jul 30, 2024
View reviewed changes
amt/core/csrf.py Show resolved Hide resolved
amt/api/routes/projects.py Outdated Show resolved Hide resolved
@ChristopherSpelt ChristopherSpelt force-pushed the 87-add-csrf-tokens-to-forms branch 2 times, most recently from 8891556 to 0bf377a Compare August 5, 2024 11:35
berrydenhartog
berrydenhartog approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berrydenhartog berrydenhartog force-pushed the 87-add-csrf-tokens-to-forms branch from 0bf377a to 2c1da8f Compare August 6, 2024 07:27
@berrydenhartog berrydenhartog disabled auto-merge August 6, 2024 07:27
@berrydenhartog berrydenhartog disabled auto-merge August 6, 2024 07:27
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChristopherSpelt ChristopherSpelt merged commit 8653524 into main Aug 6, 2024
14 checks passed
@ChristopherSpelt ChristopherSpelt deleted the 87-add-csrf-tokens-to-forms branch August 6, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CSRF tokens to forms
2 participants
@ChristopherSpelt @berrydenhartog