Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated ROOS design system #120

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Integrated ROOS design system #120

merged 1 commit into from
Aug 29, 2024

Conversation

rubenrouwhof
Copy link
Contributor

@rubenrouwhof rubenrouwhof commented Jul 31, 2024 •
edited by uittenbroekrobbert
Loading

Description

Integrate ROOS with NL Design system into AMT.

What we did

  • Installed libraries from ROOS design system with NPM
  • Changed the design to use the ROOS components

Resolves #127

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

github-actions[bot]
github-actions bot reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to our community 🤗 and thank you for your first contribution.

As a first time contributor please make sure to review our contribution guidelines ❤️

@laurensWe laurensWe force-pushed the poc-roos-design-system branch 2 times, most recently from 113cfb9 to 18ce712 Compare August 21, 2024 13:41
@laurensWe laurensWe linked an issue Aug 21, 2024 that may be closed by this pull request
Set-up frontend build system with NLDS for AMT #127
Closed
@laurensWe
Copy link
Member

This is also dependent on PR #145, as that build system is better w.r.t. user rights

@laurensWe laurensWe marked this pull request as ready for review August 21, 2024 13:46
@laurensWe laurensWe requested a review from a team as a code owner August 21, 2024 13:46
@laurensWe laurensWe force-pushed the poc-roos-design-system branch 3 times, most recently from ce7622a to df864ac Compare August 27, 2024 13:35
@uittenbroekrobbert uittenbroekrobbert changed the title Poc roos design system Integrated ROOS design system Aug 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

berrydenhartog
berrydenhartog approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurensWe laurensWe merged commit 4fc108b into main Aug 29, 2024
16 checks passed
@laurensWe laurensWe deleted the poc-roos-design-system branch August 29, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@berrydenhartog berrydenhartog berrydenhartog approved these changes

@laurensWe laurensWe Awaiting requested review from laurensWe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set-up frontend build system with NLDS for AMT
3 participants
@rubenrouwhof @laurensWe @berrydenhartog