Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change ci.yml in order to be able to run it with act locally #144

Merged
merged 4 commits into from
Aug 20, 2024
Merged

change ci.yml in order to be able to run it with act locally #144

merged 4 commits into from
Aug 20, 2024

Conversation

laurensWe
Copy link
Member

Description

These specific changes are needed in order for act to work:

  • Add extra environment variable (like timezone TZ)
  • Caching is done in a different way
  • Only run one Python version
  • Excluded jobs and steps when running locally

Resolves #119

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

Sorry, something went wrong.

@laurensWe laurensWe requested a review from a team as a code owner August 20, 2024 10:04
@laurensWe laurensWe linked an issue Aug 20, 2024 that may be closed by this pull request
Change CI/CD to support ACT #119
Closed
@laurensWe laurensWe force-pushed the 119-change-cicd-to-support-act branch from bd7b5ee to 166303f Compare August 20, 2024 11:24
@laurensWe laurensWe force-pushed the 119-change-cicd-to-support-act branch from 166303f to 2003e93 Compare August 20, 2024 11:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

berrydenhartog
berrydenhartog approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurensWe laurensWe merged commit f655982 into main Aug 20, 2024
15 checks passed
@laurensWe laurensWe deleted the 119-change-cicd-to-support-act branch August 20, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change CI/CD to support ACT
2 participants
@laurensWe @berrydenhartog