Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for HTS header and loading module javascript #177

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix for HTS header and loading module javascript #177

merged 1 commit into from
Sep 4, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Sep 3, 2024 •
edited
Loading

This PR fixes the following issues:

  • the value for the header Strict-Transport-Security was incorrect
  • files with a .mjs extension are now loaded as type module instead of text/javascript

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner September 3, 2024 10:00
@uittenbroekrobbert uittenbroekrobbert force-pushed the bug/fix-strict-transport-security-header branch 3 times, most recently from 3980a92 to 4a8939f Compare September 3, 2024 11:28
@uittenbroekrobbert uittenbroekrobbert force-pushed the bug/fix-strict-transport-security-header branch from 4a8939f to 60b3531 Compare September 4, 2024 06:42
anneschuth
anneschuth approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/e2e/test_resources.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@uittenbroekrobbert uittenbroekrobbert merged commit b49a460 into main Sep 4, 2024
16 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the bug/fix-strict-transport-security-header branch September 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneschuth anneschuth anneschuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uittenbroekrobbert @anneschuth