Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user friendly feedback on exceptions #221

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add user friendly feedback on exceptions #221

merged 1 commit into from
Oct 7, 2024

Conversation

berrydenhartog
Copy link
Member

Description

Changes the way the exception are handled for user friendly feedback

Resolves #148

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog linked an issue Sep 30, 2024 that may be closed by this pull request
Add user friendly feedback when an exception occurs #148
Closed
@berrydenhartog berrydenhartog force-pushed the 148-add-user-friendly-feedback-when-an-exception-occurs branch 6 times, most recently from ab38a3f to 969c370 Compare October 1, 2024 09:43
@berrydenhartog berrydenhartog marked this pull request as ready for review October 1, 2024 09:44
@berrydenhartog berrydenhartog requested a review from a team as a code owner October 1, 2024 09:44
@berrydenhartog berrydenhartog force-pushed the 148-add-user-friendly-feedback-when-an-exception-occurs branch 4 times, most recently from 9fe98d2 to 4d2e8a5 Compare October 3, 2024 13:18
ChristopherSpelt
ChristopherSpelt previously approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor point

amt/locale/nl_NL/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
@berrydenhartog berrydenhartog force-pushed the 148-add-user-friendly-feedback-when-an-exception-occurs branch 2 times, most recently from 167b020 to 0b76bd5 Compare October 7, 2024 09:08
@berrydenhartog berrydenhartog force-pushed the 148-add-user-friendly-feedback-when-an-exception-occurs branch from 0b76bd5 to 41f197b Compare October 7, 2024 09:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@berrydenhartog berrydenhartog merged commit 8ce3dff into main Oct 7, 2024
16 checks passed
@berrydenhartog berrydenhartog deleted the 148-add-user-friendly-feedback-when-an-exception-occurs branch October 7, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add user friendly feedback when an exception occurs
2 participants
@berrydenhartog @ChristopherSpelt