Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more editable fields #445

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add more editable fields #445

merged 1 commit into from
Jan 15, 2025

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Dec 20, 2024 •
edited
Loading

Description

Make it possible to add editable fields to objects, like the algorithm/system_card or other objects.

Resolves a number of other unrelated issues:

  • unclosed session errors for the authorization object
  • reusing the TaskRegistryAPIClient to speed up interacting with the task-registry
  • fixes the SystemCard object to reflect the actual scheme (so it contains a lot more fields)

Resolves #379

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert linked an issue Dec 20, 2024 that may be closed by this pull request
Edit objects in "Algorithm details" section #379
Closed
@uittenbroekrobbert uittenbroekrobbert force-pushed the 379-edit-objects-in-algorithm-details-section branch 5 times, most recently from 93014bb to fcf7469 Compare January 13, 2025 08:05
@uittenbroekrobbert uittenbroekrobbert marked this pull request as ready for review January 13, 2025 12:21
@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner January 13, 2025 12:21
@uittenbroekrobbert uittenbroekrobbert force-pushed the 379-edit-objects-in-algorithm-details-section branch 9 times, most recently from a0638d7 to 23ca589 Compare January 15, 2025 09:34
@uittenbroekrobbert
Add more editable fields
db4e620 
# Conflicts:
#	amt/api/routes/algorithm.py
#	amt/locale/base.pot
#	amt/locale/en_US/LC_MESSAGES/messages.mo
#	amt/locale/en_US/LC_MESSAGES/messages.po
#	amt/locale/nl_NL/LC_MESSAGES/messages.mo
#	amt/locale/nl_NL/LC_MESSAGES/messages.po
#	tests/api/routes/test_algorithm.py
#	tests/e2e/test_create_algorithm.py
#	tests/fixtures/vcr_cassettes/test_fetch_task_with_invalid_urn.yml
#	tests/fixtures/vcr_cassettes/test_fetch_task_with_urn.yml
#	tests/fixtures/vcr_cassettes/test_fetch_task_with_urns.yml
#	tests/fixtures/vcr_cassettes/test_fetch_task_with_valid_and_invalid_urn.yml
#	tests/fixtures/vcr_cassettes/test_fetch_tasks_all.yml
#	tests/fixtures/vcr_cassettes/test_get_assessment_card.yml
#	tests/fixtures/vcr_cassettes/test_get_model_card.yml
#	tests/fixtures/vcr_cassettes/test_get_system_card_data_page.yml
#	tests/fixtures/vcr_cassettes/test_get_system_card_instruments.yml
#	tests/fixtures/vcr_cassettes/test_get_system_card_requirements.yml
@uittenbroekrobbert uittenbroekrobbert force-pushed the 379-edit-objects-in-algorithm-details-section branch from 23ca589 to db4e620 Compare January 15, 2025 09:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
82.0% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

rubenrouwhof
rubenrouwhof approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@rubenrouwhof rubenrouwhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uittenbroekrobbert uittenbroekrobbert merged commit 9bb527b into main Jan 15, 2025
14 of 15 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 379-edit-objects-in-algorithm-details-section branch January 15, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenrouwhof rubenrouwhof rubenrouwhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit objects in "Algorithm details" section
2 participants
@uittenbroekrobbert @rubenrouwhof