Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Systemcard template pilot ready #473

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Systemcard template pilot ready #473

merged 3 commits into from
Jan 28, 2025

Conversation

ravimeijerrig
Copy link
Contributor

Description

In this PR we:

  • Empty the systemcard template and replace by dummy variables if needed

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ravimeijerrig ravimeijerrig requested a review from a team as a code owner January 17, 2025 10:56
@ravimeijerrig ravimeijerrig linked an issue Jan 17, 2025 that may be closed by this pull request
Systemcard pilot ready maken #459
Closed
uittenbroekrobbert
uittenbroekrobbert previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ravimeijerrig
Merge branch 'main' into 459-systemcard-pilot-ready-maken
10ec486 
Signed-off-by: Ravi Meijer <ravi.meijer@rijksoverheid.nl>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ChristopherSpelt
ChristopherSpelt approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ravimeijerrig ravimeijerrig merged commit e3397b0 into main Jan 28, 2025
15 checks passed
@ravimeijerrig ravimeijerrig deleted the 459-systemcard-pilot-ready-maken branch January 28, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Systemcard pilot ready maken
3 participants
@ravimeijerrig @ChristopherSpelt @uittenbroekrobbert