Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requirements widget and speed up dealing with requirements #476

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

uittenbroekrobbert
Copy link
Contributor

Description

The requirement widgets was not showing the correct status. Other fixes include:

  • the requirements are now links
  • on click, a requirement is shown on the page (scroll to) and "openend"
  • when editing a measure, the page is reloaded to the requirement you were working on
  • the order of users (icons) is now consistent with the order in the form

Scope creep fixes: organization filter does not show the option 'all' any more as this is not a working option at the moment

Resolves #456

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner January 20, 2025 10:43
@uittenbroekrobbert uittenbroekrobbert linked an issue Jan 20, 2025 that may be closed by this pull request
@uittenbroekrobbert uittenbroekrobbert force-pushed the 456-bug-completed-requirements branch from c739f74 to f542a15 Compare January 20, 2025 10:47
@uittenbroekrobbert uittenbroekrobbert force-pushed the 456-bug-completed-requirements branch from f542a15 to dc71435 Compare January 20, 2025 10:57
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.0% Coverage on New Code (required ≥ 95%)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uittenbroekrobbert uittenbroekrobbert merged commit 9b2dd45 into main Jan 20, 2025
14 of 15 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 456-bug-completed-requirements branch January 20, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug 'Completed' Requirements
2 participants