Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tasks for measures when creating an algorithm #478

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Add tasks for measures when creating an algorithm #478

merged 1 commit into from
Jan 24, 2025

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Jan 22, 2025 •
edited
Loading

Description

Add tasks for measures when creating an algorithm.

Additional fixes:

  • width for the UI has been changed to max 1280px instead of 960px

Resolves #385

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner January 22, 2025 10:36
@uittenbroekrobbert uittenbroekrobbert linked an issue Jan 22, 2025 that may be closed by this pull request
Show measures on tasks tab on algorithm page #385
Closed
7 tasks
@uittenbroekrobbert uittenbroekrobbert force-pushed the 385-show-measures-on-tasks-tab-on-algorithm-page branch 8 times, most recently from 5d9647a to 0787177 Compare January 22, 2025 14:33
@uittenbroekrobbert uittenbroekrobbert force-pushed the 385-show-measures-on-tasks-tab-on-algorithm-page branch from 0787177 to dd8d11a Compare January 24, 2025 07:47
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
93.9% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

ChristopherSpelt
ChristopherSpelt approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uittenbroekrobbert uittenbroekrobbert merged commit 967e36c into main Jan 24, 2025
14 of 15 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 385-show-measures-on-tasks-tab-on-algorithm-page branch January 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show measures on tasks tab on algorithm page
2 participants
@uittenbroekrobbert @ChristopherSpelt