Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language support #50

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Add language support #50

merged 1 commit into from
Jun 27, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Jun 19, 2024 •
edited by ChristopherSpelt
Loading

Description

Add support for multi language to the TAD project.

https://github.com/orgs/MinBZK/projects/7?pane=issue&itemId=66071991

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert linked an issue Jun 19, 2024 that may be closed by this pull request
Make TAD multi language / translatable #49
Closed
@ChristopherSpelt ChristopherSpelt marked this pull request as ready for review June 25, 2024 10:30
@ChristopherSpelt ChristopherSpelt requested a review from a team as a code owner June 25, 2024 10:30
@uittenbroekrobbert uittenbroekrobbert force-pushed the 49-make-tad-multi-language--translatable branch 4 times, most recently from bc96cdc to dd7fef7 Compare June 26, 2024 07:30
berrydenhartog
berrydenhartog reviewed Jun 26, 2024
View reviewed changes
script/pybabel-for-tad Outdated Show resolved Hide resolved
script/start Outdated Show resolved Hide resolved
script/translate Show resolved Hide resolved
script/translate Show resolved Hide resolved
tad/api/deps.py Show resolved Hide resolved
tad/api/routes/tasks.py Outdated Show resolved Hide resolved
tad/core/config.py Outdated Show resolved Hide resolved
tad/core/config.py Outdated Show resolved Hide resolved
tad/core/internationalization.py Outdated Show resolved Hide resolved
tad/site/static/js/tad.js Show resolved Hide resolved
laurensWe
laurensWe previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) And works nicely!

script/pybabel-for-tad Show resolved Hide resolved
@uittenbroekrobbert uittenbroekrobbert force-pushed the 49-make-tad-multi-language--translatable branch from d34c1ff to 43b59cc Compare June 27, 2024 12:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@berrydenhartog berrydenhartog merged commit 95538a4 into main Jun 27, 2024
14 checks passed
@berrydenhartog berrydenhartog deleted the 49-make-tad-multi-language--translatable branch June 27, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

@laurensWe laurensWe laurensWe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make TAD multi language / translatable
4 participants
@uittenbroekrobbert @laurensWe @berrydenhartog @ChristopherSpelt