Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check on uniq urns across all instruments #13

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add a check on uniq urns across all instruments #13

merged 1 commit into from
Jul 8, 2024

Conversation

anneschuth
Copy link
Member

Description

Add a check on uniq urns across all instruments

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@anneschuth anneschuth requested a review from a team as a code owner July 8, 2024 07:36
@anneschuth anneschuth self-assigned this Jul 8, 2024
laurensWe
laurensWe approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChristopherSpelt
ChristopherSpelt reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, which might not be strictly necessary if we only use this script in this repo and always expect data to be a dict or a list of dicts.

script/validate Show resolved Hide resolved
GuusjeJuijn
GuusjeJuijn approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@GuusjeJuijn GuusjeJuijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Smart idea to add this function :)

berrydenhartog
berrydenhartog approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anneschuth anneschuth merged commit 56ae69b into main Jul 8, 2024
6 checks passed
@anneschuth anneschuth deleted the feature/check-uniq-urns branch July 8, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurensWe laurensWe laurensWe approved these changes

@berrydenhartog berrydenhartog berrydenhartog approved these changes

@GuusjeJuijn GuusjeJuijn GuusjeJuijn approved these changes

@ravimeijerrig ravimeijerrig Awaiting requested review from ravimeijerrig

@ChristopherSpelt ChristopherSpelt Awaiting requested review from ChristopherSpelt

Assignees

@anneschuth anneschuth

Labels
None yet
Projects
👾 AI Validation Team Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anneschuth @laurensWe @berrydenhartog @ChristopherSpelt @GuusjeJuijn