Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #88.
So
/construction/combine
takesunsigned_transaction
from the/construction/payloads
output and combines it with the signature producingsigned_transaction
as output. The unsigned_transaction is signed outside MinaMesh. AFAIK there are following signers available:Documentation on signing: https://docs.minaprotocol.com/exchange-operators/rosetta/samples/using-signer.
1. Sign
Using Ocaml-signer the transaction can be signed as follows:
2. Combine
👇
Notes:
/construction/combine
allows many signatures (signatures: Vec<models::Signature>
) only the first one is read, therefore I've added check to allow only 1 signature (which does not exist in Ocaml)however in Ocaml the
signing_payload
andpublic_key
are not verified, therefore here we also only validate thehex_bytes
verifying if it can be successfully decoded intomina_signer::Signature
, we also verify ifSignatureType
isSignatureType::SchnorrPoseidon
.signer
perhaps we should also consider adding one into MinaMesh 💡 .