Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorials test-features CI #1058

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Fix tutorials test-features CI #1058

merged 5 commits into from
Oct 17, 2024

Conversation

45930
Copy link
Contributor

@45930 45930 commented Oct 15, 2024

Fixes a CI failure on main from my last commit

@45930 45930 requested a review from a team as a code owner October 15, 2024 20:59
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
07-oracles ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 9:58pm

@45930
Copy link
Contributor Author

45930 commented Oct 15, 2024

@boray - Is there a reason not to run the CI on PRs as well as on push to main?

@boray
Copy link
Contributor

boray commented Oct 15, 2024

@boray - Is there a reason not to run the CI on PRs as well as on push to main?

yes, to save Github Actions cost. But, you can manually run from Actions tab.

@boray
Copy link
Contributor

boray commented Oct 15, 2024

In the context of this PR, you cannot run this version of the workflow in Github Actions. But, you can still test it locally with act.

.github/workflows/test-tutorials.yml Outdated Show resolved Hide resolved
.github/workflows/test-tutorials.yml Outdated Show resolved Hide resolved
@45930 45930 requested a review from boray October 16, 2024 21:56
Copy link
Contributor

@boray boray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@45930 45930 merged commit fe8980b into main Oct 17, 2024
3 checks passed
@45930 45930 deleted the 2024-10-fix-ci branch October 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants