-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreign fields pt 2 #777
Foreign fields pt 2 #777
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
||
#### Defined in | ||
|
||
[lib/foreign-field.ts:477](https://github.com/o1-labs/snarkyjs/blob/9d34c7fcf/src/lib/foreign-field.ts#L477) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this link auto-resolves to o1js, but do we want to keep snarkyjs
in our links?
|
||
# Class: Unconstrained<T\> | ||
|
||
Container which holds an unconstrained value. This can be used to pass values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Container which holds an unconstrained value. This can be used to pass values | |
Container which holds an unconstrained value. You can use this to pass values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we want to make the API docs actionable, but if we did, this would be a valid suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The API docs are generated so changing them here is not the right place, I will take it as feedback for improving the doccomments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitschabaude see the minor update suggestions.
Our docs style is to use the second person pronoun "you" and avoid using third person "we"
https://developers.google.com/style/person
Co-authored-by: Barrie Byron <barrie@o1labs.org>
Additional content about foreign fields on top of #774
TODO:
ForeignField
and update links that should point to it