docs/feat: zk lightnet #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
barriebyron
added
docs
|
Early bit of feedback: I think 'a lightnet' sounds awkward. Even 'the lightnet' feels a little off to me. I think the issue is that we refer to it as if it's an establisehd thing but it's just our name. Would suggest referring to 'a/the local network' instead. If we need to use 'lightnet' then I think we should use it like a proper noun and still avoid 'a' or 'the'. Totally get that it's a draft so I hope this isn't premature! |
barriebyron
commented
Jan 5, 2024
garwalsh
reviewed
Jan 24, 2024
nicc
reviewed
Jan 25, 2024
nicc
reviewed
Jan 25, 2024
nicc
reviewed
Jan 25, 2024
nicc
reviewed
Jan 25, 2024
docs/zkapps/lightnet.mdx
Outdated
| zk lightnet status | ||
| ``` | ||
|
|
||
| The network status is returned, including useful URLs. For example, the default single node network status returns these useful URLs: |
There was a problem hiding this comment.
Suggested change
| The network status is returned, including useful URLs. For example, the default single node network status returns these useful URLs: | |
| The network status is returned, including useful URLs. For example, the default single node network status returns these endpoints: |
??
There was a problem hiding this comment.
Your question marks mean you have a question? Can you elaborate please? @nicc
nicc
reviewed
Jan 25, 2024
nicc
reviewed
Jan 25, 2024
nicc
reviewed
Jan 25, 2024
nicc
reviewed
Jan 25, 2024
Co-authored-by: garwalsh <gwalsh@gmail.com> Co-authored-by: Nic Young <20563+nicc@users.noreply.github.com>
garwalsh
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #726 and begins the work to document the workflow for testing with the lightnet
Files for review
Sidebar updates
Other updates, with more to follow in the next PR: