Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus scraper for jobportal busniess metrics provided by n8n #29

Merged

Conversation

oliverbeck-dev
Copy link
Contributor

  • add prometheus scraper for meilisearch
  • remove stash comments
  • add prometheus scraper for jobportal business metrics provided by n8n

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ansible-build ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 2:47pm

{% if prometheus_n8n_business_metrics_jobportal_username is defined %}
- job_name: n8n business metrics jobportal https
metrics_path: "/webhook/metrics-jobportal"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das ist Sozialinfo spezifisch und darf somit nicht ins Template.

Wie wurde dieser endpoint defineirt? Ist das ein Custom N8N-Webhook? Wenn ja sollten wir das anders lösen.

Ich würde prüfen ob sich die N8N /metrics erweitern lassen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja das ist ein custom webhook. wir machen dies jetzt via n8n, da wir von dort aus business bezogene metriken aus mehreren quellsystemen (typo3, odoo, meilisearch etc.) zusammen publizieren können.

die offiziellen n8n metriken können nicht erweitert werden, das haben wir bereits geprüft. können wir es irgendwie in unser inventory zügeln?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverbeck-dev Wir können das prometheus.yml so erweitern, dass man ganze Scraper-Configs hinzufügen kann.

prometheus_scrapers:
  - job_name: n8n business metrics jobportal https
    metrics_path: "/webhook/metrics-jobportal"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverbeck-dev Kannst du den job_name: n8n business metrics jobportal https von diesem PR entfernen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich kann ihn entfernen, wir brauchen einfach zeitnah eine alternative lösung, da diese metrics bereits im einsatz sind. sonst können wir nicht mehr deployen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist gelöst mit einer variable

@@ -58,6 +58,7 @@
- "{{ prometheus_port }}:9090"
networks:
- name: "{{ docker_network_name }}"
network_mode: bridge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das mint-system network läuft im Bridge-Mode. Daher kann das entfernt werden.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@janikvonrotz janikvonrotz merged commit 8accad7 into Mint-System:main Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants