Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve include/exclude handling and some small cleanup #875

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Improve include/exclude handling and some small cleanup #875

merged 5 commits into from
Jan 2, 2025

Conversation

bennybp
Copy link
Contributor

@bennybp bennybp commented Jan 2, 2025

Description

Some small cleanups related to some upcoming features

  1. Make handling whether something is included/excluded more consistent & tested
  2. Add some batching in get_general
  3. Adding dataset info to the cache should just add ids directly (rather than records, from which IDs are then extracted)
  4. Handle contributed_values in datasets when constructed from a cache/view

Status

  • Code base linted
  • Ready to go

@bennybp bennybp merged commit bf839b2 into main Jan 2, 2025
14 of 15 checks passed
@bennybp bennybp deleted the cleanup branch January 2, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bennybp